Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undetectable mock annotations with attributes above. #281

Merged
merged 4 commits into from
Dec 7, 2024
Merged

Fix undetectable mock annotations with attributes above. #281

merged 4 commits into from
Dec 7, 2024

Conversation

sidepelican
Copy link
Collaborator

mockolo cannot detect the mock annotation in code like the following:

@MainActor
/// @mockable
protocol P {
}

This PR fixes this issue.

@sidepelican sidepelican requested review from fummicc1 and uhooi December 5, 2024 07:18
fummicc1
fummicc1 requested changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@fummicc1 fummicc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I found one case that should be supported.

Sources/MockoloFramework/Parsers/SwiftSyntaxExtensions.swift Outdated Show resolved Hide resolved
@sidepelican sidepelican requested a review from fummicc1 December 7, 2024 10:50
fummicc1
fummicc1 approved these changes Dec 7, 2024
View reviewed changes
Copy link
Collaborator

@fummicc1 fummicc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for fixing fragile test as well. :)

@sidepelican sidepelican merged commit e15f91f into uber:master Dec 7, 2024
3 checks passed
@sidepelican sidepelican deleted the attributed_decl branch December 7, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fummicc1 fummicc1 fummicc1 approved these changes

@uhooi uhooi Awaiting requested review from uhooi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidepelican @fummicc1