Compile fixture code with macro #282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/MockoloFramework/Templates/ClosureTemplate.swift # Sources/MockoloFramework/Templates/NominalTemplate.swift # Tests/MockoloTestCase.swift # Tests/TestSendable/FixtureSendable.swift
This reverts commit a226737.
# Conflicts: # Tests/MockoloTestCase.swift # Tests/TestActor/FixtureGlobalActor.swift # Tests/TestArgumentsHistory/FixtureArgumentsHistory.swift # Tests/TestEmojis/FixtureEmojis.swift # Tests/TestFuncs/TestBasicFuncs/FixtureNonSimpleFuncs.swift # Tests/TestFuncs/TestFuncAsync/FixtureFuncAsync.swift # Tests/TestOverloads/FixtureInheritance.swift # Tests/TestPATs/FixturePAT.swift
sidepelican
force-pushed
the
fixture_validation
branch
from
9e8e4cd to
54a8f4a
Compare
|
We don't replace all the tests in this PR. To validate the approach, only some of the tests have been updated. |
|
The following two test cases have been commented out because they were incorrect (they won't be fixed in this PR):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are many Fixtures in the mockolo test code, but they are not statically checked by the compiler.
As a result, incorrect code may be tested.
In this PR, we introduce the
@Fixturemacro and change the tests to use actual Swift code.The real Swift code will be validated for correctness at compile time, and the input and output of the tests will use the source code strings generated by the macro.