You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, PiranhaJS relies on the Esprima parser, which lacks support for stage 2 proposals. How can I handle decorators in my project using PiranhaJS? Can I contribute a pull request to replace Esprima with Babel parser to address this?
I've noticed that class variables are not being cleaned up at all in PiranhaJS. For instance, in the provided input and expected output example, class variables was are retained. How can we ensure proper cleanup of class variables in PiranhaJS?
Input:
class Abc {
get myFlag() {
return isFlagTreated(featureFlag);
}
method() {
return window.myVar && this.myFlag;
}
}
Expected Output:
class Abc {
method() {
return window.myVar;
}
}
Doubt: Why hasn't Javascript transitioned from legacy to Tree Sitter? Are there specific reasons for this?
Thank you for reaching out. There is no technical reason for not instantiating a js variant of polyglot piranha. It could be done. Its just that dynamic languages are tricky and require some thorough thinking. During my stint at uber, unfortunately I didnt have the bandwidth to migrate this. @dvmarcilio do we want to continue advancing the legacy implementation ? Let me know based on your priorities.
Feature request:
Currently, PiranhaJS relies on the Esprima parser, which lacks support for stage 2 proposals. How can I handle decorators in my project using PiranhaJS? Can I contribute a pull request to replace Esprima with Babel parser to address this?
I've noticed that class variables are not being cleaned up at all in PiranhaJS. For instance, in the provided input and expected output example, class variables was are retained. How can we ensure proper cleanup of class variables in PiranhaJS?
Input:
Expected Output:
Doubt: Why hasn't Javascript transitioned from legacy to Tree Sitter? Are there specific reasons for this?
@anag004 @s7rthak @mkr-plse
The text was updated successfully, but these errors were encountered: