Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong grub parameters for Framework 13 laptop on bluefin-dx-framework #444

Closed
bmp opened this issue Aug 28, 2023 · 9 comments
Closed

Wrong grub parameters for Framework 13 laptop on bluefin-dx-framework #444

bmp opened this issue Aug 28, 2023 · 9 comments

Comments

@bmp
Copy link

bmp commented Aug 28, 2023

Hello,

I am have a Framework 13 laptop, and it comes with an Integrated GPU (mine is the 11th Generation Intel model), i.e Iris Xe Graphics as indicated Frame.work's website. However, the bluefin-dx-framework edition has the following parameters for GRUB,

GRUB_CMDLINE_LINUX="rd.driver.blacklist=nouveau modprobe.blacklist=nouveau nvidia-drm.modeset=1 rd.luks.options=discard rhgb quiet"

As posted in the discussion, is this intentional? If not, can this be removed in newer builds?

@bmp
Copy link
Author

bmp commented Aug 28, 2023

As suggested, I have removed the noveau and nvidia portion using rpm-ostree kargs --editor, the new file reads,

rd.luks.options=discard rhgb quiet root=UUID=035cb8ce-3f98-450c-b408-067ed085279b rootflags=subvol=root rw module_blacklist=hid_sensor_hub nvme.noacpi=1 tpm_tis.interrupts=0 rd.luks.options=discard

Here is the output of cat /proc/cmdline,

BOOT_IMAGE=(hd0,gpt2)/ostree/default-89803050ac8cf78abe750ba86d4766e074e393d73b36c1fa9e0188f6ea09f05c/vmlinuz-6.4.12-200.fc38.x86_64 rd.luks.options=discard rhgb quiet root=UUID=035cb8ce-3f98-450c-b408-067ed085279b rootflags=subvol=root rw module_blacklist=hid_sensor_hub nvme.noacpi=1 tpm_tis.interrupts=0 rd.luks.options=discard ostree=/ostree/boot.1/default/89803050ac8cf78abe750ba86d4766e074e393d73b36c1fa9e0188f6ea09f05c/0

However, I see the following (duplicate entries and maybe wrongly timestamped) in the Grub when I boot,

Fedora Linux 38.20230827.0 (Bluefin) (ostree:0)
Fedora Linux 38. 20230827.0 (Bluefin) Costree:1)
Fedora Linux 38.20230827.0 (Bluefin) (astree:0)
Fedora Linux 38.20230827.0 (Bluefin) Castree:1)
UEFI Firnware Settings

While I had installed Bluefin for the first time yesterday and only layered neofetch, today I ran rpm-ostree kargs --editor, shouldn't the new entry reflect today's date? Or does running kargs option only change previous entry and not produce a new image?

@bobslept
Copy link
Contributor

bobslept commented Aug 28, 2023

We currently not set those kargs automaticly. Even for the nvidia image where they are for we ask the user to set them manually in the installation guide.

Good to hear you were able to remove them. They should not change automaticly, until you do it yourself. By hand via rpm-ostree kargs or maybe by just someaction. So they will stay as you have them at this moment.

Then on the grub menu. The duplicate lines are a bug, which they are working on. That is the two times ostree: 1 and ostree: 0 you see in your menu. I think it will be fixed in F39, but don't take my word on it.

Last but not least, the timestamp. We base our main image on another image provided by fedora from overhere and build an image from that every 24h. So it could be that timestamp, that represent the build date of the image upstream is a day off. An example.

State: idle
AutomaticUpdates: stage; rpm-ostreed-automatic.timer: last run 8min ago
Deployments:
● ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:38 (index: 0)
                   Digest: sha256:52a0216618333074a64ebb64e284da6ec03cf03195adb7a5aa15d4957113a440
                  Version: 38.20230828.0 (2023-08-28T10:09:48Z)
                   Commit: b30f0870805e7e0d9985f71df0d653835acc93c03dca6d481836d419ec69f8f2
                   Staged: no
                StateRoot: fedora

  ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:38 (index: 1)
                   Digest: sha256:d42fd6c5b7fdb8d774433de39fb8d23fc90f96ea2147bc8418225ef6af326aed
                  Version: 38.20230827.0 (2023-08-28T01:05:20Z)
                   Commit: d21b5c1c79b1b8862f80b5d0788b4a8071aadca4ca6e6478d9be4970951131c2
                StateRoot: fedora

The ostree index 1 I build this night on the 28 but has a version of 27 of august (which you see in grub). Index 0 was build on the regular scheduled rebuild this morning and there we see the timestamp matching with the day. The fact we have an index 0 and a index 1. In this case the index 0 is currently booted, and the index 1 is the previous image before upgrading. So you can always roll back into that one if the new one has problems.

I hope that makes a little sense all together.

@bmp
Copy link
Author

bmp commented Aug 28, 2023

@bobslept, thank you for the detailed explanation!

  1. I have followed the guide provided to run just framework-13. Based on the Just page, I checked the repo, to check for the framework-13 command and couldn't find it! Is there another place for me to look at?

  2. For the duplicate entries in GRUB, the issue you have linked to actually states,

This is still planned to be included in F39 but not there yet due to https://pagure.io/workstation-ostree-config/pull-request/330#comment-190406 (the PR has been reverted).

The test images ([gitlab.com/fedora/ostree/ci-test](https://gitlab.com/fedora/ostree/ci-test)) include this already. The Universal Blue images should as well.

This would mean Universal Blue images should not have duplicate entries right? Or are they referening to Universal Blue images for F39?

  1. The timestamp makes sense now :-).

Edited as I rebooted and noticed the behaviour you mentioned for GRUB timestamps.

@bobslept
Copy link
Contributor

bobslept commented Aug 28, 2023

Yeah I have no clue where those kargs came from. The only other place I can find them are in the just file for nvidia. I have rebased to a bluefin-dx-framework image and it didn't set those kargs for me. The just set-kargs-nvidia which sets these kargs is available so if that would be run by the user, it ends up with those kargs. Maybe you can look for it in your bash history like history | grep nvidia to see if that has been run by accident?

I have rebased to the silverblue:38 from upstream I mentioned and it still had the double entries in grub. That's were we are building of currently. And also rebased to silverblue:39 which also has the double grub lines. So I am not sure.

@bmp
Copy link
Author

bmp commented Aug 28, 2023

So, as I had nothing better to do and since installing Bluefin is such a breeze, I reinstalled bluefin-framework and here is the output of cat /proc/cmdline before I ran just framework-13,

BOOT_IMAGE=(hd0,gpt2)/ostree/default-4b2b184889d4ed2ff4c5336433e9f1e290017f8b1808a2923e5a1fdf6544f24a/vmlinuz-6.4.12-200.fc38.x86_64 rd.luks.options=discard rhgb quiet root=UUID=0b100620-d48b-40d4-844b-3862c420fa84 rootflags=subvol=root rw ostree=/ostree/boot.0/default/4b2b184889d4ed2ff4c5336433e9f1e290017f8b1808a2923e5a1fdf6544f24a/0

will update this post after a the command shortly.

Here is the output now after I ran just framework-13 and reboooted,

BOOT_IMAGE=(hd0,gpt2)/ostree/default-4b2b184889d4ed2ff4c5336433e9f1e290017f8b1808a2923e5a1fdf6544f24a/vmlinuz-6.4.12-200.fc38.x86_64 rd.luks.options=discard rhgb quiet root=UUID=0b100620-d48b-40d4-844b-3862c420fa84 rootflags=subvol=root rw ostree=/ostree/boot.1/default/4b2b184889d4ed2ff4c5336433e9f1e290017f8b1808a2923e5a1fdf6544f24a/0 module_blacklist=hid_sensor_hub nvme.noacpi=1 tpm_tis.interrupts=0 rd.luks.options=discard

So must be something to do with the bluefin-dx-framework image right?

@bsherman
Copy link
Contributor

Helpful tip.

One can easily see what a just COMMAND will do before running it

$ just --dry-run update
rpm-ostree update
flatpak update -y
distrobox upgrade -a

So if there's any question about what a just command is doing, this should answer it without any need to dig.

@bmp
Copy link
Author

bmp commented Aug 29, 2023

An uptade: I am on bluefin-framework and see no problem when I run just framework-13.

Where can I read what the bluefin-dx-framework adds in addition?

@bobslept
Copy link
Contributor

The dx stands for developer experience. Like bluefin-framework what will stands for bluefin + framework addons. Bluefin-dx-framework wil give you bluefin + developer experience + framework addons. You can read more about bluefin-dx ships and what it's all about over here. It adds things like VScode, virt-manager and lots more.

@bmp
Copy link
Author

bmp commented Aug 29, 2023

@bobslept thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants