Discussing the MediaEmbed element 🎥

[welcometogithubletsbegintheadventur]

Little doubt about deserialization

This is code from getMediaEmbedDeserialize

return {
    element: getNodeDeserializer({
      type: options.type,
      getNode: (el: HTMLElement) => {
        let url = el.getAttribute('src');
        if (url) {
          [url] = url.split('?');

          return {
            type: options.type,
            url,
          };
        }
      },
      rules: [
        { nodeNames: 'IFRAME' },
        { className: getSlateClass(options.type) },
      ],
      ...options.deserialize,
    }),
  };

Is it intended to split on '?', if so, why?

If I get the purpose of media embed there will be multiple sources of embeds, is this to remove some extra URL parameter in general?

A question on Twitter embeds

Is there any discussion around how Twitter embeds will be implemented?

I believe the embed original URL(sent by the user) should always be kept, in case the way of generating a embed changes. Twitter has this website https://publish.twitter.com/, and some best practices https://developer.twitter.com/en/docs/twitter-for-websites/embedded-tweets/guides/cms-best-practices that could be helpful. What is the "Plate way" of approaching this?

[dylans]

Short answer is I don't remember, it has been that way for a while.

At one point I also added https://github.com/udecode/plate/blob/main/packages/elements/media-embed-ui/src/MediaEmbedElement/MediaEmbedUrlInput.tsx#L18-L29 so someone could paste full embed code and we could parse the URL.

I'd be fine with a PR that removes the split on ? provided that it also works for parsing when someone pastes the full html embed code. Or I can look at it sometime soon.

Twitter sort of by default insists on a JS widget rather than an iframe. I was thinking of detecting twitter URLs and doing something like https://twitframe.com/.

[welcometogithubletsbegintheadventur]

Thank you, the split don't really has an odd behavior on my code, one thing is that my HTML content had oEmbed components, that were parsed, I parsed them myself to iframe to let Plate deserialize it, which worked like a charm, except for some URLs like for example https://www.youtube.com/watch?v=752ndK2u_fs, this doesn't make a real embed, rather it should be https://www.youtube.com/embed/752ndK2u_fs. My case was very specific so it's not really a Plate problem, I'm happy to be using Plate now, everything is so much easier, unless deserializing oembed is also under the scope for the media embed

[zbeyens]

For Twitter, I've opened a discussion #1109