Issues with the header of the tables #2250
Unanswered
albertoramosmoinsendi
asked this question in
Q&A
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
While working on the migration from version 11 to version 15 of plate we have found that in version 11 of plate-table there is a change from
getEmptyTableNode(editor)
togetEmptyTableNode(editor, { rowCount: 2, colCount: 2})
and no change until version 15, whereaddRow
is removed forinsertTableRow
andaddColumn
forinsertTableColumn
.By making these changes and testing on the playground we noticed errors within the table related to the header. The problem with the header is that we always have to set it to false when creating the inserTableRow, but we can't do the same for the columns. This way we have places where we don't want to have the header if we start adding columns and rows. This is how it worked before: https://codesandbox.io/s/sandpack-project-forked-c7m08y?file=/App.tsx and this is what it should look like:
The problem can be recreated here: https://codesandbox.io/s/sandpack-project-forked-k5nj87?file=/table/TableToolbarButtons.tsx and how the bug looks like:
It's the same TabletoolbarButtons.tsx file and the same functionality and should work the same way.
Beta Was this translation helpful? Give feedback.
All reactions