Plugin deserialize validAttribute

[joephela]

Question if what I'm trying to do with my deserialize rules makes sense and whether or not I've run into a bug. In a custom plugin I have the following:

deserializeHtml: {
    isElement: true,
    rules: [
      {
        validAttribute: { href: '' },
        validNodeName: 'A',
      },
    ],
  }

To support some existing data I have to convert <a href="" target=""></a> to our new plugin component.

plate/packages/core/src/plugins/html-deserializer/utils/pluginDeserializeHtml.ts

Lines 96 to 99 in 9864885

	const elAttribute = el.getAttribute(attributeName);
	if (!elAttribute || !attributeValues.includes(elAttribute))
	return false;

I'm seeing that elAttribute ='' in my case which is correct, but since its negated the expression will evaluate to true which in turn causes our matching to fail.

I could see this same issue arise if someone were to search for a tabindex=0. Just wondering if this is intended functionality or an oversight?

[12joan]

We should be able to update the condition to elAttribute === null. @zbeyens Can you think of any cases where this might cause problems?

[12joan]

@joephela Can you try changing it and opening a PR to see if any tests fail?

[zbeyens]

isDefined could be used

[12joan]

According to MDN, all modern browsers consistently return null when the attribute isn't present, but I don't see any harm in using !isDefined.

[joephela]

Threw a PR out (#2400) Unsure of the changeset process for this project, so left that undone for now.