Why were the editor plugins prop's type arguments removed in #2671?

[OliverWales]

A change to usePlateEffects.ts in this commit removed the generics from the plugins argument to the editor (PlatePlugin<PluginOptions, V, E>[] -> PlatePlugin[]). This is causing a bunch of type issues for us. What was the reason behind this change? I know I can probably just get away with a cast but this feels like a step back:

[zbeyens]

We've loosen up the PlatePlugin[] types (only for arrays) as it was painful to type in most places. PlatePlugin types should still work with custom Value and Editor as long as they extend these. What kind of error are you having?

[OliverWales]

Here's the error we're getting:

Type 'PlatePlugin<AnyObject, MyValue, MyEditor>[]' is not assignable to type 'PlatePlugin<AnyObject, Value, PlateEditor<Value>>[]'.
  Type 'PlatePlugin<AnyObject, MyValue, MyEditor>' is not assignable to type 'PlatePlugin<AnyObject, Value, PlateEditor<Value>>'.
    Type 'PlatePlugin<AnyObject, MyValue, MyEditor>' is not assignable to type '{ editor?: Nullable<{ insertData?: PlatePluginInsertData<Value> | undefined; }> | undefined; handlers?: Nullable<DOMHandlers<AnyObject, Value, PlateEditor<...>> & { ...; }> | undefined; ... 8 more ...; type?: string | undefined; }'.
      Types of property 'editor' are incompatible.
        Type 'Nullable<{ insertData?: PlatePluginInsertData<MyValue> | undefined; }> | undefined' is not assignable to type 'Nullable<{ insertData?: PlatePluginInsertData<Value> | undefined; }> | undefined'.ts(2322)
index.d.ts(1275, 5): The expected type comes from property 'plugins' which is declared here on type 'IntrinsicAttributes & PlateProps<MyValue, PlateEditor<MyValue>>'

[OliverWales]

And our types are as follows:

export type MyValue = MyRootBlock[];
export type MyEditor = PlateEditor<MyValue>;

export type MyRootBlock =
  | MyParagraphElement
  | MyH1Element
  | MyH2Element
  | MyH3Element
  ...

Where everything in MyRootBlock extends MyBlockElement which extends TElement

[zbeyens]

Where do you declare your plugins? createPlugins? It can be fixed by removing the generics there.

[OliverWales]

Hmm, that works for most but some of our custom plugins rely on the editor being of type MyEditor 😔

But casting those specific plugins is nicer than casting the whole list given the rest don't mind 👍🏻

[zbeyens]

I generally cast my plugins individually, since each plugin can have a different options type. Using MyPlatePlugin<P> to make it shorter.