Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete forward on empty line before code block unwraps code line #2686

Closed
12joan opened this issue Oct 7, 2023 · 9 comments · Fixed by #2687
Closed

Delete forward on empty line before code block unwraps code line #2686

12joan opened this issue Oct 7, 2023 · 9 comments · Fixed by #2687

Comments

@12joan
Copy link
Collaborator

12joan commented Oct 7, 2023

Description

When deleting forward from an empty paragraph immediately before a code block, the first line of the code block is unwrapped. This makes it impossible to remove such a paragraph if the code block should be at the start of the document.

Steps to Reproduce

  1. Go to platejs.org
  2. Create an empty paragraph followed by a code block containing at least two lines
  3. Place the cursor at the empty paragraph
  4. Delete forward
recording.mp4

Expected Behavior

  • If the paragraph is empty, delete forward should delete it without affecting the code block.
  • If the paragraph is non-empty, the current behaviour is acceptable.

This is consistent with lists:

recording.mp4

Bounty

Click here to add a bounty via Algora.

Funding

  • You can sponsor this specific effort via a Polar.sh pledge below
  • We receive the pledge once the issue is completed & verified
Fund with Polar
@12joan 12joan added bug Something isn't working plugin:code-block labels Oct 7, 2023
@12joan
Copy link
Collaborator Author

12joan commented Oct 7, 2023

/bounty $100

@algora-pbc
Copy link

algora-pbc bot commented Oct 7, 2023

💎 $100 bounty created by 12joan
🙋 If you start working on this, comment /attempt #2686 to notify everyone
👉 To claim this bounty, submit a pull request that includes the text /claim #2686 somewhere in its body
📝 Before proceeding, please make sure you can receive payouts in your country
💵 Payment arrives in your account 2-5 days after the bounty is rewarded
💯 You keep 100% of the bounty award
🙏 Thank you for contributing to udecode/plate!

Attempt Started (GMT+0) Solution
🟢 @Hitesh-Sisara Oct 7, 2023, 7:02:59 PM WIP
🟢 @Vishal-Sikka Oct 7, 2023, 7:10:36 PM WIP
🟢 @prateekkalra Oct 7, 2023, 7:13:30 PM WIP
🟢 @archie9211 Oct 8, 2023, 1:11:16 AM #2687

@Hitesh-Sisara
Copy link

Hitesh-Sisara commented Oct 7, 2023

/attempt #2686

Options

1 similar comment
@Vishal-Sikka
Copy link

Vishal-Sikka commented Oct 7, 2023

/attempt #2686

Options

@algora-pbc
Copy link

algora-pbc bot commented Oct 7, 2023

Note: The user @Hitesh-Sisara is already attempting to complete issue #2686 and claim the bounty. If you attempt to complete the same issue, there is a chance that @Hitesh-Sisara will complete the issue first, and be awarded the bounty. We recommend discussing with @Hitesh-Sisara and potentially collaborating on the same solution versus creating an alternate solution.

@prateekkalra
Copy link

prateekkalra commented Oct 7, 2023

/attempt #2686

Options

@archie9211
Copy link
Contributor

archie9211 commented Oct 8, 2023

/attempt #2686

Options

@algora-pbc
Copy link

algora-pbc bot commented Oct 8, 2023

💡 @archie9211 submitted a pull request that claims the bounty. You can visit your org dashboard to reward.
👉 @archie9211: To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay on your dashboard.

@algora-pbc
Copy link

algora-pbc bot commented Oct 10, 2023

🎉🎈 @archie9211 has been awarded $100! 🎈🎊

zbeyens added a commit that referenced this issue Oct 10, 2023
Delete forward on empty line before code block unwraps code line #2686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants