Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad ToolbarButton typing #2711

Closed
Feshchenko opened this issue Oct 23, 2023 · 3 comments · Fixed by #2873
Closed

Bad ToolbarButton typing #2711

Feshchenko opened this issue Oct 23, 2023 · 3 comments · Fixed by #2873
Assignees
Labels
bug Something isn't working

Comments

@Feshchenko
Copy link

Feshchenko commented Oct 23, 2023

Description

Hey @zbeyens thanks for you hard work.

The generated ToolbarButton has bad typing.

After toolbar generation, you will have a dustructured value in the
https://github.com/udecode/plate/blob/main/templates/plate-playground-template/src/components/plate-ui/toolbar.tsx#L91
If your eslint rule no-unused-vars is set to error you will get an error.
If you delete this value then you will get the type string | number | string[] here
https://github.com/udecode/plate/blob/main/templates/plate-playground-template/src/components/plate-ui/toolbar.tsx#L120
But, ToolbarToggleItem expects string 🤷‍♂️

Steps to Reproduce

Environment

  • IDE
  • CI
  • terminal

Bounty

Click here to add a bounty via Algora.

Funding

  • You can sponsor this specific effort via a Polar.sh pledge below
  • We receive the pledge once the issue is completed & verified
Fund with Polar
@Feshchenko Feshchenko added the bug Something isn't working label Oct 23, 2023
@zbeyens
Copy link
Member

zbeyens commented Oct 24, 2023

Thanks for the report. PR's welcome!

@lalitkumawat1m
Copy link

Hello @zbeyens, I want to work on this issue please assign it to me.
Thanks in advance.

@12joan
Copy link
Collaborator

12joan commented Oct 24, 2023

@lalitkumawat1m In general, you don't need to worry about getting issues assigned to you before working on them. Unless there's a bounty, the chances of multiple people working on them at the same time are quite slim.

@Feshchenko Feshchenko changed the title Bad ToolbarButton typeing Bad ToolbarButton typing Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants