Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkToolbarButton does nothing #2778

Closed
Feshchenko opened this issue Nov 29, 2023 · 3 comments
Closed

LinkToolbarButton does nothing #2778

Feshchenko opened this issue Nov 29, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@Feshchenko
Copy link

Feshchenko commented Nov 29, 2023

Description

The link toolbar button doesn't convert the node to the ELEMENT_LINK

Steps to Reproduce

  1. add link element https://platejs.org/docs/components/link-element
  2. add link toolbar button https://platejs.org/docs/components/link-toolbar-button
  3. add createLinkPlugin https://platejs.org/docs/link#createlinkplugin
  4. LinkElement doesn't appear in the editor

Sandbox

Plate link bug

Expected Behavior

After clicking on the link toolbar button node should be converted to LinkElement or LinkElement should be inserted to the parent.

Environment

  • slate:
  • slate-react:
  • browser: chrome

Bounty

Click here to add a bounty via Algora.

Funding

  • You can sponsor this specific effort via a Polar.sh pledge below
  • We receive the pledge once the issue is completed & verified
Fund with Polar
@Feshchenko Feshchenko added the bug Something isn't working label Nov 29, 2023
@zbeyens
Copy link
Member

zbeyens commented Nov 29, 2023

Added to the docs the missing option:

createLinkPlugin({
  renderAfterEditable: LinkFloatingToolbar
}),

@zbeyens zbeyens closed this as completed Nov 29, 2023
@Feshchenko
Copy link
Author

@zbeyens not sure I get the fix. There is no information about renderAfterEditable option.

@12joan
Copy link
Collaborator

12joan commented Nov 29, 2023

@Feshchenko You can find information about that option by searching for it on Plate's docs site. Here's the link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants