From 28ab09b545c13607f41e564bae4dd7709b6c909b Mon Sep 17 00:00:00 2001 From: Na'aman Hirschfeld Date: Tue, 24 Dec 2024 22:34:07 +0100 Subject: [PATCH 1/4] chore: revolsed typescript build issues --- .../r/styles/default/comments-plugin.json | 2 +- packages/ai/src/lib/BaseAIPlugin.ts | 4 +-- packages/ai/tsconfig.build.json | 1 - packages/alignment/tsconfig.build.json | 1 - packages/autoformat/tsconfig.build.json | 1 - packages/basic-elements/tsconfig.build.json | 1 - packages/basic-marks/tsconfig.build.json | 1 - packages/block-quote/tsconfig.build.json | 1 - packages/break/tsconfig.build.json | 1 - packages/callout/tsconfig.build.json | 1 - packages/callout/tsconfig.json | 1 - packages/caption/tsconfig.build.json | 1 - packages/cli/tsconfig.build.json | 1 - packages/cmdk/src/cmdk.tsx | 5 ++-- packages/cmdk/tsconfig.build.json | 1 - packages/cn/tsconfig.build.json | 1 - packages/code-block/tsconfig.build.json | 1 - packages/combobox/tsconfig.build.json | 1 - packages/comments/tsconfig.build.json | 1 - packages/common/tsconfig.build.json | 1 - .../core/src/lib/plugins/getCorePlugins.ts | 14 +--------- .../lib/static/utils/stripHtmlClassNames.ts | 9 +++---- .../react/components/PlateControllerEffect.ts | 11 ++++++-- .../plate-controller/plateControllerStore.ts | 6 ++--- packages/core/tsconfig.build.json | 1 - packages/csv/tsconfig.build.json | 1 - packages/cursor/tsconfig.build.json | 1 - packages/date/tsconfig.build.json | 1 - packages/diff/tsconfig.build.json | 1 - packages/dnd/tsconfig.build.json | 1 - packages/docx/tsconfig.build.json | 1 - packages/emoji/tsconfig.build.json | 1 - packages/excalidraw/tsconfig.build.json | 1 - packages/find-replace/tsconfig.build.json | 1 - packages/floating/tsconfig.build.json | 1 - packages/font/tsconfig.build.json | 1 - packages/heading/tsconfig.build.json | 1 - packages/highlight/tsconfig.build.json | 1 - packages/horizontal-rule/tsconfig.build.json | 1 - packages/indent-list/tsconfig.build.json | 1 - packages/indent/tsconfig.build.json | 1 - packages/juice/tsconfig.build.json | 1 - packages/kbd/tsconfig.build.json | 1 - .../layout/src/lib/utils/columnsToWidths.ts | 2 +- packages/layout/tsconfig.build.json | 1 - packages/line-height/tsconfig.build.json | 1 - packages/link/tsconfig.build.json | 1 - packages/list/tsconfig.build.json | 1 - packages/markdown/tsconfig.build.json | 1 - packages/math/tsconfig.build.json | 1 - packages/media/tsconfig.build.json | 1 - packages/mention/tsconfig.build.json | 1 - packages/node-id/tsconfig.build.json | 1 - packages/normalizers/tsconfig.build.json | 1 - packages/plate-utils/tsconfig.build.json | 1 - packages/plate/tsconfig.build.json | 1 - packages/playwright/tsconfig.build.json | 1 - packages/react-hotkeys/tsconfig.build.json | 1 - packages/react-utils/tsconfig.build.json | 1 - packages/reset-node/tsconfig.build.json | 1 - packages/resizable/tsconfig.build.json | 1 - packages/select/tsconfig.build.json | 1 - packages/selection/src/internal/types.ts | 3 +-- .../src/internal/utils/intersects.ts | 3 +-- packages/selection/tsconfig.build.json | 1 - packages/slash-command/tsconfig.build.json | 1 - packages/slate-react/tsconfig.build.json | 1 - packages/slate-utils/tsconfig.build.json | 1 - packages/slate/tsconfig.build.json | 1 - packages/suggestion/tsconfig.build.json | 1 - packages/tabbable/tsconfig.build.json | 1 - packages/table/tsconfig.build.json | 1 - packages/tag/tsconfig.build.json | 1 - packages/test-utils/tsconfig.build.json | 1 - packages/toggle/tsconfig.build.json | 1 - packages/trailing-block/tsconfig.build.json | 1 - packages/utils/tsconfig.build.json | 1 - packages/yjs/tsconfig.build.json | 1 - tsconfig.json | 27 ++++++++++--------- yarn.lock | 6 ++--- 80 files changed, 42 insertions(+), 118 deletions(-) diff --git a/apps/www/public/r/styles/default/comments-plugin.json b/apps/www/public/r/styles/default/comments-plugin.json index ee7eeb91eb..37e5370148 100644 --- a/apps/www/public/r/styles/default/comments-plugin.json +++ b/apps/www/public/r/styles/default/comments-plugin.json @@ -4,7 +4,7 @@ ], "files": [ { - "content": "'use client';\n\nimport { CommentsPlugin } from '@udecode/plate-comments/react';\n\nimport { CommentsPopover } from '@/components/plate-ui/comments-popover';\n\nexport const commentsPlugin = CommentsPlugin.configure({\n options: {\n myUserId: '1',\n users: {\n 1: {\n id: '1',\n avatarUrl: 'https://avatars.githubusercontent.com/u/19695832?s=96&v=4',\n name: 'zbeyens',\n },\n 2: {\n id: '2',\n avatarUrl: 'https://avatars.githubusercontent.com/u/4272090?v=4',\n name: '12joan',\n },\n },\n },\n render: { afterEditable: () => },\n});\n", + "content": "'use client';\n\nimport { CommentsPlugin } from '@udecode/plate-comments/react';\n\nimport { commentsData } from '@/components/values/comments-value';\nimport { CommentsPopover } from '@/components/plate-ui/comments-popover';\n\nexport const commentsPlugin = CommentsPlugin.configure({\n options: {\n comments: commentsData,\n myUserId: '1',\n users: {\n 1: {\n id: '1',\n avatarUrl: 'https://avatars.githubusercontent.com/u/19695832?s=96&v=4',\n name: 'zbeyens',\n },\n 2: {\n id: '2',\n avatarUrl: 'https://avatars.githubusercontent.com/u/4272090?v=4',\n name: '12joan',\n },\n },\n },\n render: { afterEditable: () => },\n});\n", "path": "components/editor/plugins/comments-plugin.tsx", "target": "components/editor/plugins/comments-plugin.tsx", "type": "registry:component" diff --git a/packages/ai/src/lib/BaseAIPlugin.ts b/packages/ai/src/lib/BaseAIPlugin.ts index d1cc95ed5e..2132b22380 100644 --- a/packages/ai/src/lib/BaseAIPlugin.ts +++ b/packages/ai/src/lib/BaseAIPlugin.ts @@ -1,8 +1,8 @@ import { - type OmitFirst, - type PluginConfig, bindFirst, createTSlatePlugin, + type OmitFirst, + type PluginConfig, } from '@udecode/plate-common'; import { removeAIMarks, undoAI } from './transforms'; diff --git a/packages/ai/tsconfig.build.json b/packages/ai/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/ai/tsconfig.build.json +++ b/packages/ai/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/alignment/tsconfig.build.json b/packages/alignment/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/alignment/tsconfig.build.json +++ b/packages/alignment/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/autoformat/tsconfig.build.json b/packages/autoformat/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/autoformat/tsconfig.build.json +++ b/packages/autoformat/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/basic-elements/tsconfig.build.json b/packages/basic-elements/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/basic-elements/tsconfig.build.json +++ b/packages/basic-elements/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/basic-marks/tsconfig.build.json b/packages/basic-marks/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/basic-marks/tsconfig.build.json +++ b/packages/basic-marks/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/block-quote/tsconfig.build.json b/packages/block-quote/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/block-quote/tsconfig.build.json +++ b/packages/block-quote/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/break/tsconfig.build.json b/packages/break/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/break/tsconfig.build.json +++ b/packages/break/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/callout/tsconfig.build.json b/packages/callout/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/callout/tsconfig.build.json +++ b/packages/callout/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/callout/tsconfig.json b/packages/callout/tsconfig.json index 425481e027..b54ca40a99 100644 --- a/packages/callout/tsconfig.json +++ b/packages/callout/tsconfig.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/caption/tsconfig.build.json b/packages/caption/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/caption/tsconfig.build.json +++ b/packages/caption/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/cli/tsconfig.build.json b/packages/cli/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/cli/tsconfig.build.json +++ b/packages/cli/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/cmdk/src/cmdk.tsx b/packages/cmdk/src/cmdk.tsx index a459bad427..451b2af298 100644 --- a/packages/cmdk/src/cmdk.tsx +++ b/packages/cmdk/src/cmdk.tsx @@ -246,7 +246,6 @@ const Command = React.forwardRef( const propsRef = useAsRef(props); const { children, - disablePointerSelection = false, filter, label, loop, @@ -664,9 +663,9 @@ const Command = React.forwardRef( selectFirstItem, selectItem: updateSelectedToIndex, selectLastItem: last, - selectNextGroup: (e) => updateSelectedByGroup(1), + selectNextGroup: () => updateSelectedByGroup(1), selectNextItem: next, - selectPrevGroup: (e) => updateSelectedByGroup(-1), + selectPrevGroup: () => updateSelectedByGroup(-1), selectPrevItem: prev, setSearch, }; diff --git a/packages/cmdk/tsconfig.build.json b/packages/cmdk/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/cmdk/tsconfig.build.json +++ b/packages/cmdk/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/cn/tsconfig.build.json b/packages/cn/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/cn/tsconfig.build.json +++ b/packages/cn/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/code-block/tsconfig.build.json b/packages/code-block/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/code-block/tsconfig.build.json +++ b/packages/code-block/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/combobox/tsconfig.build.json b/packages/combobox/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/combobox/tsconfig.build.json +++ b/packages/combobox/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/comments/tsconfig.build.json b/packages/comments/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/comments/tsconfig.build.json +++ b/packages/comments/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/common/tsconfig.build.json b/packages/common/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/common/tsconfig.build.json +++ b/packages/common/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/core/src/lib/plugins/getCorePlugins.ts b/packages/core/src/lib/plugins/getCorePlugins.ts index 5225284aff..6e6659a67d 100644 --- a/packages/core/src/lib/plugins/getCorePlugins.ts +++ b/packages/core/src/lib/plugins/getCorePlugins.ts @@ -1,28 +1,16 @@ import type { AnyPluginConfig, PluginConfig } from '../plugin/BasePlugin'; import type { SlatePlugin } from '../plugin/SlatePlugin'; - -import { - createSlatePlugin, - createTSlatePlugin, -} from '../plugin/createSlatePlugin'; import { AstPlugin } from './AstPlugin'; import { DOMPlugin } from './DOMPlugin'; import { HistoryPlugin } from './HistoryPlugin'; import { InlineVoidPlugin } from './InlineVoidPlugin'; import { ParserPlugin } from './ParserPlugin'; -import { type DebugErrorType, type LogLevel, DebugPlugin } from './debug'; +import { type DebugErrorType, DebugPlugin, type LogLevel } from './debug'; import { SlateNextPlugin } from './editor-protocol'; import { HtmlPlugin } from './html'; import { LengthPlugin } from './length'; import { BaseParagraphPlugin } from './paragraph'; -// Somehow needed to avoid cyclic dependency -// eslint-disable-next-line @typescript-eslint/no-unused-vars -const _ = () => { - createSlatePlugin(); - createTSlatePlugin(); -}; - export type CorePlugin = ReturnType[number]; export type GetCorePluginsOptions = { diff --git a/packages/core/src/lib/static/utils/stripHtmlClassNames.ts b/packages/core/src/lib/static/utils/stripHtmlClassNames.ts index bcc293fe08..4749fd77cd 100644 --- a/packages/core/src/lib/static/utils/stripHtmlClassNames.ts +++ b/packages/core/src/lib/static/utils/stripHtmlClassNames.ts @@ -23,9 +23,8 @@ export const stripHtmlClassNames = ( .split(/\s+/) .filter((cn) => preserveRegExp.test(cn)); - return classesToKeep.length === 0 - ? '' - : ` class="${classesToKeep.join(' ')}"`; - } - ); + return classesToKeep.length === 0 + ? '' + : ` class="${classesToKeep.join(' ')}"`; + }); }; diff --git a/packages/core/src/react/components/PlateControllerEffect.ts b/packages/core/src/react/components/PlateControllerEffect.ts index 36bf3ee5d5..85e52998d5 100644 --- a/packages/core/src/react/components/PlateControllerEffect.ts +++ b/packages/core/src/react/components/PlateControllerEffect.ts @@ -10,6 +10,8 @@ import { usePlateSelectors, usePlateStore, } from '../stores'; +import type { WritableAtom } from 'jotai/vanilla/atom'; +import type { JotaiStore } from 'jotai-x'; export interface PlateControllerEffectProps { id?: string; @@ -23,8 +25,13 @@ export const PlateControllerEffect = ({ const currentStoreAtom = React.useMemo( () => - focusAtom(plateControllerStore.atom.editorStores, (optic) => - optic.prop(id) + focusAtom( + plateControllerStore.atom.editorStores as WritableAtom< + Record, + any, + any + >, + (optic) => optic.prop(id) ), [id] ); diff --git a/packages/core/src/react/stores/plate-controller/plateControllerStore.ts b/packages/core/src/react/stores/plate-controller/plateControllerStore.ts index 6fad13b36f..756697859b 100644 --- a/packages/core/src/react/stores/plate-controller/plateControllerStore.ts +++ b/packages/core/src/react/stores/plate-controller/plateControllerStore.ts @@ -12,9 +12,9 @@ export const { usePlateControllerStore, } = createAtomStore( { - activeId: atom(null as string | null), - editorStores: atom({} as Record), - primaryEditorIds: atom([] as string[]), + activeId: atom(null), + editorStores: atom>({}), + primaryEditorIds: atom([]), }, { name: 'plateController', diff --git a/packages/core/tsconfig.build.json b/packages/core/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/core/tsconfig.build.json +++ b/packages/core/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/csv/tsconfig.build.json b/packages/csv/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/csv/tsconfig.build.json +++ b/packages/csv/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/cursor/tsconfig.build.json b/packages/cursor/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/cursor/tsconfig.build.json +++ b/packages/cursor/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/date/tsconfig.build.json b/packages/date/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/date/tsconfig.build.json +++ b/packages/date/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/diff/tsconfig.build.json b/packages/diff/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/diff/tsconfig.build.json +++ b/packages/diff/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/dnd/tsconfig.build.json b/packages/dnd/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/dnd/tsconfig.build.json +++ b/packages/dnd/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/docx/tsconfig.build.json b/packages/docx/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/docx/tsconfig.build.json +++ b/packages/docx/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/emoji/tsconfig.build.json b/packages/emoji/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/emoji/tsconfig.build.json +++ b/packages/emoji/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/excalidraw/tsconfig.build.json b/packages/excalidraw/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/excalidraw/tsconfig.build.json +++ b/packages/excalidraw/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/find-replace/tsconfig.build.json b/packages/find-replace/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/find-replace/tsconfig.build.json +++ b/packages/find-replace/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/floating/tsconfig.build.json b/packages/floating/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/floating/tsconfig.build.json +++ b/packages/floating/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/font/tsconfig.build.json b/packages/font/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/font/tsconfig.build.json +++ b/packages/font/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/heading/tsconfig.build.json b/packages/heading/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/heading/tsconfig.build.json +++ b/packages/heading/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/highlight/tsconfig.build.json b/packages/highlight/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/highlight/tsconfig.build.json +++ b/packages/highlight/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/horizontal-rule/tsconfig.build.json b/packages/horizontal-rule/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/horizontal-rule/tsconfig.build.json +++ b/packages/horizontal-rule/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/indent-list/tsconfig.build.json b/packages/indent-list/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/indent-list/tsconfig.build.json +++ b/packages/indent-list/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/indent/tsconfig.build.json b/packages/indent/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/indent/tsconfig.build.json +++ b/packages/indent/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/juice/tsconfig.build.json b/packages/juice/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/juice/tsconfig.build.json +++ b/packages/juice/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/kbd/tsconfig.build.json b/packages/kbd/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/kbd/tsconfig.build.json +++ b/packages/kbd/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/layout/src/lib/utils/columnsToWidths.ts b/packages/layout/src/lib/utils/columnsToWidths.ts index db9e1e415b..104b3e7982 100644 --- a/packages/layout/src/lib/utils/columnsToWidths.ts +++ b/packages/layout/src/lib/utils/columnsToWidths.ts @@ -1,4 +1,4 @@ export const columnsToWidths = ({ columns = 2 }: { columns?: number } = {}) => Array(columns) .fill(null) - .map((_, i) => `${100 / columns}%`); + .map(() => `${100 / columns}%`); diff --git a/packages/layout/tsconfig.build.json b/packages/layout/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/layout/tsconfig.build.json +++ b/packages/layout/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/line-height/tsconfig.build.json b/packages/line-height/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/line-height/tsconfig.build.json +++ b/packages/line-height/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/link/tsconfig.build.json b/packages/link/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/link/tsconfig.build.json +++ b/packages/link/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/list/tsconfig.build.json b/packages/list/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/list/tsconfig.build.json +++ b/packages/list/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/markdown/tsconfig.build.json b/packages/markdown/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/markdown/tsconfig.build.json +++ b/packages/markdown/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/math/tsconfig.build.json b/packages/math/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/math/tsconfig.build.json +++ b/packages/math/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/media/tsconfig.build.json b/packages/media/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/media/tsconfig.build.json +++ b/packages/media/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/mention/tsconfig.build.json b/packages/mention/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/mention/tsconfig.build.json +++ b/packages/mention/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/node-id/tsconfig.build.json b/packages/node-id/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/node-id/tsconfig.build.json +++ b/packages/node-id/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/normalizers/tsconfig.build.json b/packages/normalizers/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/normalizers/tsconfig.build.json +++ b/packages/normalizers/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/plate-utils/tsconfig.build.json b/packages/plate-utils/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/plate-utils/tsconfig.build.json +++ b/packages/plate-utils/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/plate/tsconfig.build.json b/packages/plate/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/plate/tsconfig.build.json +++ b/packages/plate/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/playwright/tsconfig.build.json b/packages/playwright/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/playwright/tsconfig.build.json +++ b/packages/playwright/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/react-hotkeys/tsconfig.build.json b/packages/react-hotkeys/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/react-hotkeys/tsconfig.build.json +++ b/packages/react-hotkeys/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/react-utils/tsconfig.build.json b/packages/react-utils/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/react-utils/tsconfig.build.json +++ b/packages/react-utils/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/reset-node/tsconfig.build.json b/packages/reset-node/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/reset-node/tsconfig.build.json +++ b/packages/reset-node/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/resizable/tsconfig.build.json b/packages/resizable/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/resizable/tsconfig.build.json +++ b/packages/resizable/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/select/tsconfig.build.json b/packages/select/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/select/tsconfig.build.json +++ b/packages/select/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/selection/src/internal/types.ts b/packages/selection/src/internal/types.ts index 551f44116f..6c7f62905a 100644 --- a/packages/selection/src/internal/types.ts +++ b/packages/selection/src/internal/types.ts @@ -1,8 +1,7 @@ import type { SelectionArea } from './SelectionArea'; import type { Intersection } from './utils'; -/* eslint-disable @typescript-eslint/no-unused-vars */ -export type DeepPartial = T extends (infer U)[] +export type DeepPartial = T extends unknown[] ? T : T extends HTMLElement ? T diff --git a/packages/selection/src/internal/utils/intersects.ts b/packages/selection/src/internal/utils/intersects.ts index 96adca7810..6ef7e9a85a 100644 --- a/packages/selection/src/internal/utils/intersects.ts +++ b/packages/selection/src/internal/utils/intersects.ts @@ -4,8 +4,7 @@ export function intersectsScroll( a: DOMRect, b: DOMRect, // TODO - // eslint-disable-next-line @typescript-eslint/no-unused-vars - mode: Intersection = 'touch', + _: Intersection = 'touch', container: HTMLElement ): boolean { const containerRect = container.getBoundingClientRect(); diff --git a/packages/selection/tsconfig.build.json b/packages/selection/tsconfig.build.json index 6dde1180ae..f2f0630fec 100644 --- a/packages/selection/tsconfig.build.json +++ b/packages/selection/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist", "paths": { "@viselect/vanilla": [ diff --git a/packages/slash-command/tsconfig.build.json b/packages/slash-command/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/slash-command/tsconfig.build.json +++ b/packages/slash-command/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/slate-react/tsconfig.build.json b/packages/slate-react/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/slate-react/tsconfig.build.json +++ b/packages/slate-react/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/slate-utils/tsconfig.build.json b/packages/slate-utils/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/slate-utils/tsconfig.build.json +++ b/packages/slate-utils/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/slate/tsconfig.build.json b/packages/slate/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/slate/tsconfig.build.json +++ b/packages/slate/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/suggestion/tsconfig.build.json b/packages/suggestion/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/suggestion/tsconfig.build.json +++ b/packages/suggestion/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/tabbable/tsconfig.build.json b/packages/tabbable/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/tabbable/tsconfig.build.json +++ b/packages/tabbable/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/table/tsconfig.build.json b/packages/table/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/table/tsconfig.build.json +++ b/packages/table/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/tag/tsconfig.build.json b/packages/tag/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/tag/tsconfig.build.json +++ b/packages/tag/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/test-utils/tsconfig.build.json b/packages/test-utils/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/test-utils/tsconfig.build.json +++ b/packages/test-utils/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/toggle/tsconfig.build.json b/packages/toggle/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/toggle/tsconfig.build.json +++ b/packages/toggle/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/trailing-block/tsconfig.build.json b/packages/trailing-block/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/trailing-block/tsconfig.build.json +++ b/packages/trailing-block/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/utils/tsconfig.build.json b/packages/utils/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/utils/tsconfig.build.json +++ b/packages/utils/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/packages/yjs/tsconfig.build.json b/packages/yjs/tsconfig.build.json index 425481e027..b54ca40a99 100644 --- a/packages/yjs/tsconfig.build.json +++ b/packages/yjs/tsconfig.build.json @@ -1,7 +1,6 @@ { "extends": "../../config/tsconfig.build.json", "compilerOptions": { - "declarationDir": "./dist", "outDir": "./dist" }, "include": ["src"] diff --git a/tsconfig.json b/tsconfig.json index b953aee44c..9db1a4db7c 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,27 +1,28 @@ { - "awesomeTypescriptLoaderOptions": { - "ignoreDiagnostics": [7005] - }, "compilerOptions": { + "rootDir": ".", + "lib": ["ESNext", "DOM", "DOM.Iterable"], "allowJs": true, - "allowSyntheticDefaultImports": true, - "downlevelIteration": true, - "esModuleInterop": true, "forceConsistentCasingInFileNames": true, "isolatedModules": true, + "module": "ESNext", "jsx": "react", - "lib": ["dom", "dom.iterable", "esnext"], - "module": "esnext", - "moduleResolution": "Bundler", + "moduleResolution": "bundler", + "esModuleInterop": true, + "allowSyntheticDefaultImports": true, "noEmit": true, + "noImplicitAny": true, + "removeComments": true, "resolveJsonModule": true, "skipLibCheck": true, "sourceMap": true, "strict": true, - "target": "es2017", - "outDir": "dist", - "rootDir": ".", - "types": ["node", "jest", "@testing-library/jest-dom"] + "strictBindCallApply": true, + "strictFunctionTypes": true, + "strictNullChecks": true, + "strictPropertyInitialization": true, + "target": "ESNext", + "types": ["node","@testing-library/jest-dom"] }, "exclude": ["node_modules", "**/node_modules", "dist", "**/dist"] } diff --git a/yarn.lock b/yarn.lock index 3dea3d6773..079272c905 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6371,7 +6371,7 @@ __metadata: dependencies: "@udecode/plate-combobox": "npm:41.0.0" "@udecode/plate-markdown": "npm:41.0.0" - "@udecode/plate-selection": "npm:41.0.0" + "@udecode/plate-selection": "npm:41.0.6" ai: "npm:^3.4.10" lodash: "npm:^4.17.21" peerDependencies: @@ -7219,7 +7219,7 @@ __metadata: languageName: unknown linkType: soft -"@udecode/plate-selection@npm:41.0.0, @udecode/plate-selection@workspace:^, @udecode/plate-selection@workspace:packages/selection": +"@udecode/plate-selection@npm:41.0.6, @udecode/plate-selection@workspace:^, @udecode/plate-selection@workspace:packages/selection": version: 0.0.0-use.local resolution: "@udecode/plate-selection@workspace:packages/selection" dependencies: @@ -7453,7 +7453,7 @@ __metadata: "@udecode/plate-reset-node": "npm:41.0.0" "@udecode/plate-resizable": "npm:41.0.0" "@udecode/plate-select": "npm:41.0.0" - "@udecode/plate-selection": "npm:41.0.0" + "@udecode/plate-selection": "npm:41.0.6" "@udecode/plate-slash-command": "npm:41.0.0" "@udecode/plate-suggestion": "npm:41.0.0" "@udecode/plate-tabbable": "npm:41.0.0" From 93a5914795d71c7dad4e787225282bfa5800d5e9 Mon Sep 17 00:00:00 2001 From: Na'aman Hirschfeld Date: Tue, 24 Dec 2024 22:54:11 +0100 Subject: [PATCH 2/4] chore: update tsconfig --- apps/www/tsconfig.json | 14 +------------- apps/www/tsconfig.scripts.json | 2 -- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/apps/www/tsconfig.json b/apps/www/tsconfig.json index b48e6c6f5a..0b1e3e9c8d 100644 --- a/apps/www/tsconfig.json +++ b/apps/www/tsconfig.json @@ -1,17 +1,6 @@ { + "extends": "../../tsconfig.json", "compilerOptions": { - "target": "es5", - "lib": ["dom", "dom.iterable", "esnext"], - "allowJs": true, - "skipLibCheck": true, - "strict": true, - "forceConsistentCasingInFileNames": true, - "noEmit": true, - "esModuleInterop": true, - "module": "esnext", - "moduleResolution": "Bundler", - "resolveJsonModule": true, - "isolatedModules": true, "jsx": "preserve", "incremental": true, "baseUrl": "src", @@ -25,7 +14,6 @@ "name": "next" } ], - "strictNullChecks": true }, "include": [ ".eslintrc.cjs", diff --git a/apps/www/tsconfig.scripts.json b/apps/www/tsconfig.scripts.json index 7d81d8fcb5..c3b89bd9fb 100644 --- a/apps/www/tsconfig.scripts.json +++ b/apps/www/tsconfig.scripts.json @@ -1,8 +1,6 @@ { - "$schema": "https://json.schemastore.org/tsconfig", "extends": "./tsconfig.json", "compilerOptions": { - "target": "es6", "module": "ESNext", "moduleResolution": "node", "esModuleInterop": true, From 6fd4e934a970f2795ad731f62cba90f4d301c402 Mon Sep 17 00:00:00 2001 From: Na'aman Hirschfeld Date: Tue, 24 Dec 2024 23:00:35 +0100 Subject: [PATCH 3/4] chore. reverted unintended file change --- apps/www/public/r/styles/default/comments-plugin.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/www/public/r/styles/default/comments-plugin.json b/apps/www/public/r/styles/default/comments-plugin.json index 37e5370148..ee7eeb91eb 100644 --- a/apps/www/public/r/styles/default/comments-plugin.json +++ b/apps/www/public/r/styles/default/comments-plugin.json @@ -4,7 +4,7 @@ ], "files": [ { - "content": "'use client';\n\nimport { CommentsPlugin } from '@udecode/plate-comments/react';\n\nimport { commentsData } from '@/components/values/comments-value';\nimport { CommentsPopover } from '@/components/plate-ui/comments-popover';\n\nexport const commentsPlugin = CommentsPlugin.configure({\n options: {\n comments: commentsData,\n myUserId: '1',\n users: {\n 1: {\n id: '1',\n avatarUrl: 'https://avatars.githubusercontent.com/u/19695832?s=96&v=4',\n name: 'zbeyens',\n },\n 2: {\n id: '2',\n avatarUrl: 'https://avatars.githubusercontent.com/u/4272090?v=4',\n name: '12joan',\n },\n },\n },\n render: { afterEditable: () => },\n});\n", + "content": "'use client';\n\nimport { CommentsPlugin } from '@udecode/plate-comments/react';\n\nimport { CommentsPopover } from '@/components/plate-ui/comments-popover';\n\nexport const commentsPlugin = CommentsPlugin.configure({\n options: {\n myUserId: '1',\n users: {\n 1: {\n id: '1',\n avatarUrl: 'https://avatars.githubusercontent.com/u/19695832?s=96&v=4',\n name: 'zbeyens',\n },\n 2: {\n id: '2',\n avatarUrl: 'https://avatars.githubusercontent.com/u/4272090?v=4',\n name: '12joan',\n },\n },\n },\n render: { afterEditable: () => },\n});\n", "path": "components/editor/plugins/comments-plugin.tsx", "target": "components/editor/plugins/comments-plugin.tsx", "type": "registry:component" From 5b05fec4b15bc3d696e9b9f566893826f0962e39 Mon Sep 17 00:00:00 2001 From: Ziad Beyens Date: Wed, 25 Dec 2024 18:47:45 +0100 Subject: [PATCH 4/4] Update tsconfig.json Co-authored-by: Na'aman Hirschfeld --- tsconfig.json | 1 - 1 file changed, 1 deletion(-) diff --git a/tsconfig.json b/tsconfig.json index 9db1a4db7c..fcea629fa4 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -12,7 +12,6 @@ "allowSyntheticDefaultImports": true, "noEmit": true, "noImplicitAny": true, - "removeComments": true, "resolveJsonModule": true, "skipLibCheck": true, "sourceMap": true,