Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Issues #1

Open
tylermcginnis opened this issue May 24, 2020 · 11 comments
Open

Course Issues #1

tylermcginnis opened this issue May 24, 2020 · 11 comments

Comments

@tylermcginnis
Copy link
Contributor

Example comment

title: Why React Router?
issue: description of issue.

I'll "hide" the comment when it's fixed.

@AlaaHassoun

This comment has been minimized.

@dekisr

This comment has been minimized.

@tylermcginnis

This comment has been minimized.

@dekisr

This comment has been minimized.

@tylermcginnis

This comment has been minimized.

@dekisr

This comment has been minimized.

@dekisr

This comment has been minimized.

@jacobshu

This comment has been minimized.

@jacobshu

This comment has been minimized.

@jacobshu

This comment has been minimized.

@AlbertVilaCalvo
Copy link

On the project, if you visit routes that end with a slash (like https://basketball-v5.ui.dev/bulls/articles/ or https://basketball-v5.ui.dev/players/) then the links on the sidebar have double slashes (eg https://basketball-v5.ui.dev/players//bonnie-eisenman).

Removing the last slash from url with url.slice(0, -1) in Sidebar fixes the issue.

I've seen people solving this by doing a redirect: <Redirect from="/:url*(/+)" to={pathname.slice(0, -1)} />. Source:

https://jasonwatmore.com/post/2020/03/23/react-router-remove-trailing-slash-from-urls

https://jasonwatmore.com/post/2020/03/26/react-router-relative-links-example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants