You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just installed this in a project and started seeing this warning. React 15.6.1
Warning: Unknown event handler property `onTouchTap`. It will be ignored.
in button (created by AllTemplatesContainer)
in CopyToClipboard (created by AllTemplatesContainer)
in cps-tooltip (created by i)
in i (created by AllTemplatesContainer)
in span (created by PreviewLite)
Looks like this commit e3c469d#diff-25d902c24283ab8cfbac54dfa101ad31 added support for onTouchTap but enforced it for all users, instead of just those that are using react-tap-event-plugin. Perhaps this should an an opt-in feature? I could submit a PR but wanted to have a quick discussion as to where to go with a fix.
The text was updated successfully, but these errors were encountered:
At the time, I was going to offer to fix this but after digging in to the specifics of onTouchTap, I realized its not worthwhile. onTouchTap is no longer supported with React 16.4+ (see issue #121 for react-tap-event-plugin), and that plugin is no longer a dependency for material-ui (see issue #7129 for material-ui). Instead, the commit I referenced should simply be undone. Since that would be a breaking change albeit a simple one, I'll let you decide how you want to do that. Thanks for the response!
I just installed this in a project and started seeing this warning. React 15.6.1
Looks like this commit e3c469d#diff-25d902c24283ab8cfbac54dfa101ad31 added support for onTouchTap but enforced it for all users, instead of just those that are using
react-tap-event-plugin
. Perhaps this should an an opt-in feature? I could submit a PR but wanted to have a quick discussion as to where to go with a fix.The text was updated successfully, but these errors were encountered: