Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown event handler property onTouchTap #1

Closed
filoxo opened this issue Jun 20, 2018 · 3 comments
Closed

Unknown event handler property onTouchTap #1

filoxo opened this issue Jun 20, 2018 · 3 comments

Comments

@filoxo
Copy link

filoxo commented Jun 20, 2018

I just installed this in a project and started seeing this warning. React 15.6.1

Warning: Unknown event handler property `onTouchTap`. It will be ignored.
    in button (created by AllTemplatesContainer)
    in CopyToClipboard (created by AllTemplatesContainer)
    in cps-tooltip (created by i)
    in i (created by AllTemplatesContainer)
    in span (created by PreviewLite)

Looks like this commit e3c469d#diff-25d902c24283ab8cfbac54dfa101ad31 added support for onTouchTap but enforced it for all users, instead of just those that are using react-tap-event-plugin. Perhaps this should an an opt-in feature? I could submit a PR but wanted to have a quick discussion as to where to go with a fix.

@filoxo
Copy link
Author

filoxo commented Sep 28, 2018

Thoughts on this?

@ukrbublik
Copy link
Owner

Hi. Sorry, I haven't seen your first message.
How do you want to remove this warning?
You can submit PR.

@filoxo
Copy link
Author

filoxo commented Sep 30, 2018

At the time, I was going to offer to fix this but after digging in to the specifics of onTouchTap, I realized its not worthwhile. onTouchTap is no longer supported with React 16.4+ (see issue #121 for react-tap-event-plugin), and that plugin is no longer a dependency for material-ui (see issue #7129 for material-ui). Instead, the commit I referenced should simply be undone. Since that would be a breaking change albeit a simple one, I'll let you decide how you want to do that. Thanks for the response!

@filoxo filoxo closed this as completed Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants