-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow hourly aggregation for other date ranges #2768
Comments
Are you looking to set the aggregation range within the app, or just an update to the API to allow it? We set minimum units of aggregation per date range to avoid resource intensive queries like hourly by year, etc. |
This issue is stale because it has been open for 60 days with no activity. |
Surprised this is not a thing. Would be super useful to have hourly chart across a week. Max 2 weeks really. |
@franciscao633 That seems totally fair and reasonable. Although hourly by week or sometimes even month still seems to make sense without breaking the bank. I'd be happy to open a PR for this. |
@franciscao633 thoughts here? one option would be just allow the user to select the unit. Plausible does something similar with a small dropdown menu close to the charts: https://plausible.io/plausible.io?period=7d&keybindHint=W. Umami could implement this right beside the date filter, or maybe on the bottom of the chart? |
Sorry for delayed response. I can see the |
@franciscao633 suggesting one implementation here: #3013 The idea is that there's a new icon right beside the arrows on the Because there's this (valid) concern about long running queries, we could add a logic that shows a warning if the user selects a non-recommended unit based on the date range. Suggestion this specific UX since it would allow for other secondary settings (eg. chart type) as well, and wouldn't clutter the current chart view. |
@franciscao633 had a change to take a look at this? happy to continue this work, it's a feature we would very much value in prod |
@ccrvlh Is the PR ready for review? It's still marked WIP. |
@mikecao It is a WIP. Would be great to get validation on the approach / UI before polishing it for review. EDIT: Just realized I didn't include the SS, will try to add that later today to validate the UI approach. |
@mikecao just added a couple of screenshots. |
Describe the feature or enhancement
Currently hourly stats seems to only be supported for the "last 24hrs" range. It would be great to look into hourly data for +1 week ranges.
The text was updated successfully, but these errors were encountered: