Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why we discard the PRECHARGE cmd here? #41

Open
gxflying opened this issue May 28, 2023 · 0 comments
Open

why we discard the PRECHARGE cmd here? #41

gxflying opened this issue May 28, 2023 · 0 comments

Comments

@gxflying
Copy link

hi sir, I am trying to understand the reason here in command_queue.cc#L85 , why the precharge CMD should be discarded when there is cmd which is in the same bank as the bank the precharge CMD will be issued to ?
before discarding the precharge cmd, should it better to check that the cmds ahead of the precharge cmd will hit the currently opened row of the bank which the precharge cmd will be issued to? because in this sernario, the precharge may cause those cmd a page miss , which should be a hit without the prechage.
could you please help me figure it out ?
thanks and wish your reply

return false;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant