Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: options to edit email send name, senders and destinations #773

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat: options to edit email send name, senders and destinations #773

merged 1 commit into from
Sep 4, 2024
+923 −93

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Sep 4, 2024 •
edited
Loading

What does this PR do?

Options to

  • Edit send name
  • Add/Remove Senders
  • Add/Remove Destinations

Fixes ENG-159

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

@BlankParticle Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BlankParticle and the rest of your teammates on Graphite Graphite

@BlankParticle BlankParticle marked this pull request as ready for review September 4, 2024 10:57
@BlankParticle BlankParticle merged commit 420e7a9 into main Sep 4, 2024
7 checks passed
@BlankParticle Graphite App
Copy link
Member Author

Merge activity

@BlankParticle BlankParticle deleted the blank/feat/edit-emails branch September 4, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McPizza0 McPizza0 McPizza0 approved these changes

Assignees

@BlankParticle BlankParticle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlankParticle @McPizza0