Always apply isolation when u:dir is set
#942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphillips
approved these changes
Nov 17, 2024
| @@ -102,6 +105,25 @@ | |||
| { "type": "bidiIsolation", "value": "\u2069" } | |||
| ] | |||
| }, | |||
| { | |||
| "src": ".local $world = {world :string u:dir=ltr u:id=foo} {{hello {$world}}}", | |||
There was a problem hiding this comment.
This is intended as the transitivity text, I think? Should we have one with mulitple .local declarations? or .input followed by .local?
There was a problem hiding this comment.
Eh, not sure if it's necessary. I think the important part is making sure that moving the option from the placeholder to a declaration works.
aphillips
requested changes
Nov 17, 2024
Co-authored-by: Addison Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #916 for some of the preceding discussion.
In addition to changing the directionality of a placeholder, we should treat an explicitly set
u:diroption as a request to isolate the placeholder, even if the direction matches the message's direction.This requires a small change to our default bidi strategy.
The inheritance of the option is not specified when it's set on a value that's used as a function operand, so e.g. a message like
might or might not have the placeholder isolated (depending on the implementation), while it would always be isolated in messages like
and