Skip to content

Commit 742026c

Browse files
authored
Merge pull request #51 from unity-sds/remove_github_token
Removes use of Github token provided by SSM
2 parents 98c068c + ea51c35 commit 742026c

File tree

10 files changed

+51
-408
lines changed

10 files changed

+51
-408
lines changed

backend/cmd/web/main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ func initConfig() {
108108
viper.AddConfigPath(configdir)
109109
viper.SetConfigType("yaml")
110110
viper.SetConfigName("unity")
111-
viper.SetDefault("GithubToken", "unset")
112111
viper.SetDefault("MarketplaceOwner", "unity-sds")
113112
viper.SetDefault("MarketplaceRepo", "unity-marketplace")
114113
viper.SetDefault("Workdir", filepath.Join(path, "workdir"))

backend/internal/application/config/init.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ type MarketplaceItem struct {
2020
}
2121

2222
type AppConfig struct {
23-
GithubToken string
2423
MarketplaceBaseUrl string
2524
MarketplaceOwner string
2625
MarketplaceRepo string

backend/internal/models/websocket.pb.go

Lines changed: 47 additions & 90 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

backend/internal/processes/bootstrap.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import (
2020
func BootstrapEnv(appconf *config.AppConfig) error {
2121
// Print out everything in appConfig
2222
log.Infof("AppConfig contents:")
23-
log.Infof("GithubToken: %s", appconf.GithubToken)
2423
log.Infof("MarketplaceBaseUrl: %s", appconf.MarketplaceBaseUrl)
2524
log.Infof("MarketplaceOwner: %s", appconf.MarketplaceOwner)
2625
log.Infof("MarketplaceRepo: %s", appconf.MarketplaceRepo)

backend/internal/processes/installer_test.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
func TestInstallMarketplaceApplication(t *testing.T) {
1212

1313
appConf := config2.AppConfig{
14-
GithubToken: "",
1514
MarketplaceOwner: "",
1615
MarketplaceRepo: "",
1716
AWSRegion: "",
@@ -42,7 +41,6 @@ func TestInstallMarketplaceApplication(t *testing.T) {
4241
func TestUpdateCoreConfig(t *testing.T) {
4342
store, _ := database.NewGormDatastore()
4443
appConf := config2.AppConfig{
45-
GithubToken: "",
4644
MarketplaceOwner: "",
4745
MarketplaceRepo: "",
4846
AWSRegion: "",

backend/internal/processes/messages.go

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,6 @@ func ProcessSimpleMessage(message *marketplace.SimpleMessage, conf *config.AppCo
1515
if message.Operation == "request config" {
1616
log.Info("Request Config received")
1717
return fetchConfig(conf, store)
18-
} else if message.Operation == "request parameters" {
19-
log.Info("Request Parameters received")
20-
return fetchParameters(conf)
2118
} else if message.Operation == "update config" {
2219
log.Info("Update config received")
2320
//return updateParameters()
@@ -65,23 +62,6 @@ func UpdateParameters(params *marketplace.Parameters, store database.Datastore,
6562

6663
}
6764

68-
func fetchParameters(conf *config.AppConfig) ([]byte, error) {
69-
db, err := database.NewGormDatastore()
70-
71-
params, err := db.FetchSSMParams()
72-
73-
ssm, err := aws.ReadSSMParameters(params)
74-
75-
paramwrap := marketplace.UnityWebsocketMessage_Parameters{Parameters: ssm}
76-
msg := &marketplace.UnityWebsocketMessage{Content: &paramwrap}
77-
data, err := proto.Marshal(msg)
78-
if err != nil {
79-
log.WithError(err).Error("Failed to marshal config")
80-
return nil, err
81-
}
82-
83-
return data, nil
84-
}
8565
func fetchConfig(conf *config.AppConfig, store database.Datastore) ([]byte, error) {
8666

8767
//coreconf, err := store.FetchCoreParams()
@@ -101,7 +81,6 @@ func fetchConfig(conf *config.AppConfig, store database.Datastore) ([]byte, erro
10181
}
10282

10383
appConfig := marketplace.Config_ApplicationConfig{
104-
GithubToken: conf.GithubToken,
10584
MarketplaceOwner: conf.MarketplaceOwner,
10685
MarketplaceUser: conf.MarketplaceRepo,
10786
Project: conf.Project,
@@ -123,7 +102,7 @@ func fetchConfig(conf *config.AppConfig, store database.Datastore) ([]byte, erro
123102
} else if bootstrapfailed.Owner != "" {
124103
bsoutput = "failed"
125104
}
126-
105+
127106
genconfig := &marketplace.Config{
128107

129108
ApplicationConfig: &appConfig,

0 commit comments

Comments
 (0)