Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): fix typos #893

Merged
merged 1 commit into from
Nov 29, 2024
Merged

chore(examples): fix typos #893

merged 1 commit into from
Nov 29, 2024

Conversation

iiio2
Copy link
Contributor

@iiio2 iiio2 commented Oct 10, 2024

No description provided.

@iiio2 iiio2 requested a review from pi0 as a code owner October 10, 2024 09:19
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (a58d7c9) to head (10ffc08).
Report is 190 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   77.83%   79.45%   +1.61%     
==========================================
  Files          47       43       -4     
  Lines        4286     3290     -996     
  Branches      611      796     +185     
==========================================
- Hits         3336     2614     -722     
+ Misses        933      673     -260     
+ Partials       17        3      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -3,10 +3,10 @@ import { createApp, createRouter, readJSONBody } from "h3";
export const app = createApp();

const router = createRouter()
.get("/", () => "use POST method to try!")
.get("/", () => "use GET method to try!")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, actually, is not a typo. It encourage the user to try and send POST request

@pi0 pi0 merged commit 500e672 into unjs:main Nov 29, 2024
5 checks passed
@pi0
Copy link
Member

pi0 commented Nov 29, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants