-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why resizetizer adds margin to all icons for Windows? #286
Comments
(cc @MartinZikmund, @dansiegel) |
@xperiandri I don't see any sample app to look at for reference of what you're seeing issues with. I'm assuming that what you're seeing is a result of the default Scale on the App Icon Foreground image which has long been a default value from the Uno Template and is now part of the Uno.Sdk. You could change the ForegroundScale for Windows to achieve what you'd like. |
@dansiegel thank you very much for such precise pointing.
|
Yes you can certainly override just for Windows. How exactly you do that would depend on what version the project template you created your project with. <PropertyGroup>
<!-- Using Uno.Sdk without the UnoIcon defined -->
<!-- https://platform.uno/docs/articles/external/uno.resizetizer/doc/using-uno-resizetizer.html?tabs=singleproject%2CAndroid#utilizing-sdk-properties -->
<UnoIconForegroundScale Condition="$(TargetFramework.Contains('windows10'))">1.0</UnoIconForegroundScale>
</PropertyGroup>
<ItemGroup>
<!-- Legacy projects (generally in the base.props -->
<!-- https://platform.uno/docs/articles/external/uno.resizetizer/doc/uno-resizetizer-properties.html#unoicon -->
<UnoIcon Include="$(MSBuildThisFileDirectory)Icons\icon.svg"
ForegroundFile="$(MSBuildThisFileDirectory)Icons\icon_foreground.svg"
ForegroundScale="0.65"
WindowsForegroundScale="1.0"
Color="#00000000" />
</ItemGroup>
While you can swap out the Scale or even the foreground (icon) file used based on platform, there is no way to say use one asset for the Wide Icon on Windows while using a different icon for the square icons. |
Current behavior
Margin is added to all icons
Expected behavior
Margin is added to tiles only by taking
icon.svg
size as the total size andicon_foreground.svg
as relative to the total.For all the other icons no margin is added
Environment
Package Version(s): 5.2.139
Affected platform(s):
Visual Studio:
The text was updated successfully, but these errors were encountered: