Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessageDialog sample should InitializeWithWindow #19207

Open
MartinZikmund opened this issue Jan 10, 2025 · 4 comments
Open

MessageDialog sample should InitializeWithWindow #19207

MartinZikmund opened this issue Jan 10, 2025 · 4 comments
Assignees
@Nirpendra09
Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Something isn't working

Comments

@MartinZikmund
Copy link
Member

MartinZikmund commented Jan 10, 2025 •
edited
Loading

Current behavior

Currently the samples on MessageDialog page fail due to the fact that InitializeWithWindow is not called on the MessageDialog instances

image

Follow the docs to fix this: https://platform.uno/docs/articles/features/dialogs.html?tabs=mvvm%2Cxaml#using-messagedialog

Expected behavior

No response

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response
@MartinZikmund MartinZikmund added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jan 10, 2025
@Nirpendra09
Copy link

@MartinZikmund can i take up this issue

@MartinZikmund
Copy link
Member Author

@Nirpendra09 definitely! Feel free to get started and ask questions as needed 👍

@Nirpendra09
Copy link

@MartinZikmund what's the expected behaviour. An example or illustration would be great.

@morning4coffe-dev
Copy link
Member

@Nirpendra09 The individual MessageDialogs samples should not fail with InvalidOperationException. Currently as the ShowAsync is called it fails with this error as InitializeWithWindow is not used when you run for example with Skia-only solution filter. Let me know, if you need some more help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nirpendra09 Nirpendra09

Labels
difficulty/starter 🚀 Categorizes an issue for which the difficulty level is reachable by newcomers good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinZikmund @Nirpendra09 @morning4coffe-dev