-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slow Performance with Svelte 5 #357
Comments
how can we test your repro? on my local I cannot see any performance slow down when loading the page. Is it about running dev server or build + preview? |
it seems to happen when running it in a mobile browser, like on chrome on android for example. |
Can you try using passive modifier on click handler?. Can you show performance details centered in 4s? Can you check if lodash-es being tree shaked? I always use the subpackage module, for example In dev or deployed app (build)? |
How do you do that?
I'm not sure what you mean? Do you mean for me to screenshot the performance details for 4 seconds?
Does that make it faster?
Both I should be able to get to these tonight or tomorrow, will update here when I have more info |
It should, at least in dev server, check network tab (maybe the 600ms is about loading lodash-es barrel), I Will ckeck it tmr. |
@SaintPepsi we've released |
About the lodash-es barrel, using your import in dev server lodash-es barrel chunk 256KB, using subpackage import + optimizedDeps.include ~12.5KB. The passive event modifier is configured by Svelte 5 internally when safe. |
Adding 25/100 children in the click handler is not cheap using any framework or even using VanillaJS, the problem seems not to be related to this repository, rather it seems like a problem with the logic in your reproduction. |
@userquin I think you're right, I also posted it in svelte, also with a react example except it's not happening in react. |
Describe the bug
When SVG elements are rendered to the page it causes a big performance slow down.
Parsing the HTML happens instantly, but then there is a presentation delay of over 500 ms
Reproduction
https://github.com/SaintPepsi/unplugin-icons-performance-issue-minimal-reproduction
System Info
Used Package Manager
npm
Validations
The text was updated successfully, but these errors were encountered: