Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookie “_unpoly_demo_layers_session” does not have a proper “SameSite” attribute value #15

Closed
hpvd opened this issue Sep 22, 2023 · 3 comments

Comments

@hpvd
Copy link

hpvd commented Sep 22, 2023

Bug description

Message from FF dev Tools

Cookie “_unpoly_demo_layers_session” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

Reproduction project

Demo Website
https://demo.unpoly.com/tasks

Steps to reproduce the behavior:

  1. open firefox
  2. go to https://demo.unpoly.com/tasks
  3. enable Developer Tools
  4. disable cache
  5. remove all cookies
  6. reload page
  7. see message in output (see screenshot)

Expected behavior

no warning / future-proof “SameSite” attribute value

Browser version

  • Windows
  • Firefox
  • 118

Additional context

none

2023-09-22_09h59_54

@hpvd hpvd changed the title Cookie “_unpoly_demo_layers_session” does not have a proper “SameSite” attribute value Demo: Cookie “_unpoly_demo_layers_session” does not have a proper “SameSite” attribute value Sep 22, 2023
@hpvd
Copy link
Author

hpvd commented Sep 22, 2023

Detail:
2023-09-22_17h28_52

@hpvd
Copy link
Author

hpvd commented Sep 22, 2023

related to discussion
Add CSP to demo unpoly/unpoly#540

@triskweline triskweline transferred this issue from unpoly/unpoly Nov 10, 2023
@hpvd hpvd changed the title Demo: Cookie “_unpoly_demo_layers_session” does not have a proper “SameSite” attribute value Cookie “_unpoly_demo_layers_session” does not have a proper “SameSite” attribute value Nov 10, 2023
@hpvd
Copy link
Author

hpvd commented Jan 24, 2025

no warning anymore in current version of demo (3.10)

@hpvd hpvd closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant