Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use gcp in trace command instead of aws #111

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

trevorackerman
Copy link
Contributor

Description of your changes

Fixes #

I have: updated the example trace command to refer to gcp instead of aws

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

Manually previewed readme markdown.

@Upbound-CLA
Copy link

Upbound-CLA commented Nov 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

upbound/platform-ref-gcp #111

Change Summary

  • Documentation update to correct the command example from AWS to GCP in the README.md file for the crossplane beta trace command

Potential Vulnerability

  • None identified in this change as it only updates documentation

Code Smell

  • None identified in this documentation change

Debug Log

  • None present in this change

Unintended Consequences

  • File: README.md:227
  • Code: crossplane beta trace cluster.gcp.platformref.upbound.io/platform-ref-gcp
  • Explanation: Users following the old AWS example might have existing scripts or automation that needs to be updated. It would be helpful to add a note about this being a breaking change for any automation relying on the previous AWS example.

Risk Score: 1

The change is a simple documentation fix replacing AWS references with GCP references. The risk is minimal as it only affects documentation and makes the example more accurate for the GCP platform reference.

Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the catch!

@ytsarev ytsarev merged commit 3d52e46 into upbound:main Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants