Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate App claim with Mysql backend #91

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

ytsarev
Copy link
Member

@ytsarev ytsarev commented Apr 9, 2024

Description of your changes

  • Use the recent version of configuration-gcp-database that provides database configuration and connection ready for consumption by App Claim
  • Add SKIP_DELETE
  • Extend uptest test run with Mysql Datatbase and App Claim

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

make e2e SKIP_DELETE=--skip-delete
...
--- PASS: kuttl (1014.22s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (1013.70s)
PASS
00:24:43 [ OK ] running automated tests
k get claim
NAME                                                                  SYNCED   READY   CONNECTION-SECRET                      AGE
sqlinstance.gcp.platform.upbound.io/platform-ref-gcp-database-mysql   True     True    platform-ref-gcp-database-mysql-conn   18m
sqlinstance.gcp.platform.upbound.io/platform-ref-gcp-db-postgres      True     True    platform-ref-gcp-db-conn-postgres      18m

NAME                                                  SYNCED   READY   CONNECTION-SECRET             AGE
cluster.gcp.platformref.upbound.io/platform-ref-gcp   True     True    platform-ref-gcp-kubeconfig   18m

NAME                                             SYNCED   READY   CONNECTION-SECRET             AGE
app.platform.upbound.io/platform-ref-gcp-ghost   True     True    platform-ref-gcp-ghost-conn   18m

On the workload GKE cluster:

k -n ghost get pod
NAME                                                  READY   STATUS    RESTARTS   AGE
platform-ref-gcp-ghost-828gj-5nnd5-58dd577996-hjxzt   1/1     Running   0          5m21s

k -n ghost logs -f platform-ref-gcp-ghost-828gj-5nnd5-58dd577996-hjxzt
ghost 22:24:17.50
ghost 22:24:17.50 Welcome to the Bitnami ghost container
ghost 22:24:17.50 Subscribe to project updates by watching https://github.com/bitnami/containers
ghost 22:24:17.50 Submit issues and feature requests at https://github.com/bitnami/containers/issues
ghost 22:24:17.50
ghost 22:24:17.51 INFO  ==> Configuring libnss_wrapper
ghost 22:24:17.54 INFO  ==> Validating settings in MYSQL_CLIENT_* env vars
ghost 22:24:17.57 WARN  ==> You set the environment variable ALLOW_EMPTY_PASSWORD=yes. For safety reasons, do not use this flag in a production environment.
ghost 22:24:17.58 INFO  ==> Ensuring Ghost directories exist
ghost 22:24:17.59 INFO  ==> Trying to connect to the database server
ghost 22:24:17.62 INFO  ==> Configuring database
ghost 22:24:17.67 INFO  ==> Setting up Ghost
ghost 22:24:18.78 INFO  ==> Configuring Ghost URL to http://upboundrocks.cloud/
ghost 22:24:18.83 INFO  ==> Passing admin user creation wizard
ghost 22:24:18.84 INFO  ==> Starting Ghost in background
ghost 22:24:41.21 INFO  ==> Stopping Ghost
ghost 22:24:42.11 INFO  ==> Persisting Ghost installation
ghost 22:24:42.21 INFO  ==> ** Ghost setup finished! **

ghost 22:24:42.24 INFO  ==> ** Starting Ghost **

* Use the recent version of configuration-gcp-database that provides
  database configuration and connection ready for consumption by App
  Claim
* Add SKIP_DELETE
* Extend uptest test run with Mysql Datatbase and App Claim

Signed-off-by: Yury Tsarev <[email protected]>
@ytsarev
Copy link
Member Author

ytsarev commented Apr 9, 2024

/test-examples

@ytsarev
Copy link
Member Author

ytsarev commented Apr 9, 2024

Surprisingly hitting deletion stuck with the centralized uptest run

Direct gcloud deletion attempt shows

gcloud compute networks delete platform-ref-gcp --project=official-provider-testing
The following networks will be deleted:
 - [platform-ref-gcp]

Do you want to continue (Y/n)?  y

ERROR: (gcloud.compute.networks.delete) Could not fetch resource:
 - The network resource 'projects/official-provider-testing/global/networks/platform-ref-gcp' is already being used by 'projects/official-provider-testing/global/firewalls/k8s-0a2ac94ca246f812-node-http-hc'

There is a relevant upstream hashicorp/terraform-provider-google#5948

The local deletion was clean. Will perform an additional investigation.

@ytsarev
Copy link
Member Author

ytsarev commented Apr 10, 2024

/test-examples

@ytsarev
Copy link
Member Author

ytsarev commented Apr 10, 2024

The deletion issues relate to the GKE cluster going to a RECONCILING state in the background and breaking the deletion procedure... I reduced the number of nodes in the Cluster Claim, and it helped with the test run.

I noticed some config deviations in upbound/configuration-gcp-gke#42 and will investigate separately.

This specific change is ready to be merged

@ytsarev ytsarev requested a review from haarchri April 10, 2024 12:01
@ytsarev ytsarev merged commit 4b2fff8 into upbound:main Apr 10, 2024
3 checks passed
@ytsarev ytsarev deleted the app-with-mysql branch April 10, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants