Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

altsrc: Set flags without erroring out. #742

Closed
HaoZeke opened this issue May 2, 2018 · 6 comments
Closed

altsrc: Set flags without erroring out. #742

HaoZeke opened this issue May 2, 2018 · 6 comments

Comments

@HaoZeke
Copy link

HaoZeke commented May 2, 2018

Basically I was wondering if there is a method to set flags only if the .yml file exists.

Currently it errors out (naturally, as the call is in app.Before) if the file is missing.

Is there any other way other than creating a default .yml file before checking for it?

@coilysiren
Copy link
Member

Hiya! There's a known issue with the current implementation of the CLI, where altsrc is generally clunky and poorly documented. My current idea is that I'm going to move all of the altsrc functionality into the main package in some way, and that's how all of the "altsrc is weird and different???" issues people are having will get resolved. I'm tracking that work here => #833

@HaoZeke
Copy link
Author

HaoZeke commented Aug 17, 2019

I don't know if it's a good idea to close a bunch of issues without discussing and implementing fixes. It's counter intuitive and goes against the whole point of opening and reporting issues in the first place.

@HaoZeke
Copy link
Author

HaoZeke commented Aug 17, 2019

These should ideally be kept open until they are resolved. It streamlines the discussion. A meta issue like the one you opened is not a bad idea either but not at the cost of the focused discussions which might take place on the original issue.

@AudriusButkevicius
Copy link
Contributor

I disagree, if there is a general theme in a lot of issues, they should follow a general issue.

@HaoZeke
Copy link
Author

HaoZeke commented Aug 17, 2019

Well, altsrc being weird and needing to be fixed is far too general a theme in my opinion, but then I've not used cli in ages anyway.

@coilysiren
Copy link
Member

It qualifies as a general theme in this particular case because I'm proposing we completely remove altsrc - which would make all the altsrc issues either disappear ✨ or become invalid since the code has changed so much 🌀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants