Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 0.15 #84

Open
ethereumdegen opened this issue Dec 5, 2024 · 6 comments
Open

Upgrade to 0.15 #84

ethereumdegen opened this issue Dec 5, 2024 · 6 comments

Comments

@ethereumdegen
Copy link

I was able to make the bevy portion of this crate compatible with bevy 0.15 . You can see the code here

https://github.com/ethereumdegen/transform-gizmo

@ActuallyHappening
Copy link
Contributor

Why no draft PR? Anyway, I'll need to port this to 0.15 to get bevy_editor_pls to compile. Will open PR

@ethereumdegen
Copy link
Author

No pr bc i didnt convert the examples in the root yet . Also im getting a panic when i integrated this in my own editor . The panic occurs when i deselect , and remove the targets for the gizmo. And i cant figure out the cause. The error is something about index 0 is invalid for slice 0

@ActuallyHappening
Copy link
Contributor

I didn't find any panic for my PR, maybe check mine out for differences?

@ethereumdegen
Copy link
Author

Fyi .. crash bug related to slice in 15 reported by 2 separate users

#85

@ethereumdegen
Copy link
Author

fixed the crash bug in my pr

#85 (comment)

@ethereumdegen
Copy link
Author

ethereumdegen commented Dec 18, 2024

i also pulled in the changes that Shenmarukai made in order to fix the local/global xform issue so commit cf98c4e is a version of this package that should work quite nicely with 0.15 . it is for me at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants