Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with ignore in PyPI released version #20

Open
anugrahjo opened this issue Mar 8, 2023 · 5 comments
Open

Bug with ignore in PyPI released version #20

anugrahjo opened this issue Mar 8, 2023 · 5 comments

Comments

@anugrahjo
Copy link

anugrahjo commented Mar 8, 2023

'ignore' does not work for copy and copy_folder drivers. ignore=ignore_patterns() is a kwarg for copytree() but is provided as a non-keyworded argument in copy and copy_folder drivers. Just adding the keyword ignore= will fix the issue. I see that copy driver is removed and this issue is also fixed in the github repo but not on PyPI released version. Is it possible to release the latest version on master branch to PyPI?

@jgarte
Copy link
Contributor

jgarte commented Mar 8, 2023

Interesting, I was getting this error yesterday when trying to use the copy_folder driver:

ERROR: Error executing driver CopyFolderDriver for collection foo_bar. 'ignore'

I wonder if it is related. My source and target directory definitely exists as configured in my collections dictionary in conf.py.

Did you get a similar logger warning when trying to run the copy_folder driver?

@jgarte
Copy link
Contributor

jgarte commented Mar 8, 2023

Also,

With the copy_file driver I experienced something the other day where it created a directory in the target location instead of copying my file.

@jgarte
Copy link
Contributor

jgarte commented Mar 8, 2023

@anugrahjo

Have you been able to get copy_file and/or copy_folder driver to work without ignore?

@anugrahjo
Copy link
Author

Interesting, I was getting this error yesterday when trying to use the copy_folder driver:

ERROR: Error executing driver CopyFolderDriver for collection foo_bar. 'ignore'

I wonder if it is related. My source and target directory definitely exists as configured in my collections dictionary in conf.py.

Did you get a similar logger warning when trying to run the copy_folder driver?

No, I did not.

@anugrahjo
Copy link
Author

Have you been able to get copy_file and/or copy_folder driver to work without ignore?

No I think it always requires ignore. I give an empty list [] if I don't want to ignore any files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants