Changed paths to work with build tools #82
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second 'split' PR that was discussed for splitting the big one into smaller ones. This one here #80
This PR just fixes the pathing in the library, making it work with other systems that expect a more modern approach than the one with setup tools (which is not needed anymore since python 3.3) that was used.
Setuptools was a necessary change in this PR as otherwise the tests will not work, due to failing
pip install .
fixes #79
**Note: I need some help on this PR, as I run into a small problem. I uploaded the
noxtest.py
as well so you can see how I tested this change. **When I run
nox
with this the outcome is as follows:For Sphinx 7.4.1 it works fine and has no issues but the other two versions fail. With this error:
Some more context:
This always seems to stem from the
tests/test_custom_template.py
file. All of theapp.build()
calls there fail due to this same error.I'm not sure how to fix this as I can't find the 'about.html' anywhere in the project?
Let me know if you have any more insight or need some more information from my side to triage this.