Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Base URL Support #3781

Closed
GlowingScrewdriver opened this issue Aug 2, 2024 · 3 comments
Closed

Custom Base URL Support #3781

GlowingScrewdriver opened this issue Aug 2, 2024 · 3 comments
Labels
enhancement New feature or request Stale

Comments

@GlowingScrewdriver
Copy link

Describe the solution you'd like

Would it be within the scope of the project to have support for a custom base URL? I know there has been discussion on this, e.g. in #2129 and #436, and I am also aware that the recommended way to use the server behind a reverse proxy is via a custom subdomain prefix. However, being able to use a path prefix would be useful for people who don't own public IPs, and instead make do with tunnels.

Type of feature

Integrations

Additional context

I have been hacking on the router in the Memos frontend to get it working under a subpath (albeit hardcoded), and I have had some success. It works well enough that I'm able to use it. I just wanted to discuss it here before I go ahead and develop a full solution for it. Would you be open to merging such a contribution?

@GlowingScrewdriver GlowingScrewdriver added the enhancement New feature or request label Aug 2, 2024
@github-actions github-actions bot added the Stale label Aug 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2024
@beshanoe
Copy link

beshanoe commented Nov 5, 2024

I think it's a great idea and needs to be implemented

@GlowingScrewdriver
Copy link
Author

I've been running Memos on a subpath of my server for a couple of weeks now, and it's been working fine. Check it out here:
GlowingScrewdriver/memos

@RoccoSmit
Copy link
Contributor

@boojack , not sure what the requirements are to be added to the Memos community page, but was thinking GlowingScrewdriver/memos would be a useful addition based on the previous issues regarding this being raised as well as the pr that is currently open for subdomain hosting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

3 participants