Clocktime of created memos #4520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creation date string now shows clocktime when memos are old enough to display time as date. "Sun, Mar 9." --> "Sun, Mar 9, 1:40 PM"
used `pnpm lint --fix` to fix the problems
Copy & Paste logic from MemoView.tsx left an inexistent variable in EmbeddedMemos.tsx
|
There's no need to implement such feature as it's been already implemented. If you hover the date, the tooltip would show you the exact moment. It is also available in the PWA through the sidebar menu. It's worth mentioning that I haven't read any code to know such feature exists as it is a common design practice and respected in many application. |
|
Don’t you agree that showing the clocktime right after the date it’s an UX upgrade? We’ll be able to see a post’s time without any further clicks or mouse movement while still mantaining the old ways to visualize time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading old memos I didn't had the vision of when I did that specific post because the display date only showed weekday followed by date (Sun, Mar 9). Now the display time also shows the clocktime of memo creation (Sun, Mar 9, 1:40 PM) while keeping the relative time for newest memos such as "1 hour ago". Different time formats for different countries is already accomplished via i18n.
(en-US time)
(pt-BR time)
