This repository has been archived by the owner on Aug 17, 2021. It is now read-only.
feat: unified swap #119
Merged
feat: unified swap #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: We need to merge this PR before we can merge #107. |
t8
suggested changes
Nov 21, 2020
There was a problem hiding this comment.
This is just about perfect! Only small change I see that needs to be made is the coloring of the "swap" icon on dark mode:
Clicking in the space where it should appear works. Only issue is that the button isn't visible.
The mobile support on this page is incredible as well.
Amazing work @martonlederer (and @maximousblk on the design)!
t8
approved these changes
Nov 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.