support symfony 6.4 | 7 and AssetMapper, Stimulus

[tacman]

This package is a perfect candidate for dropping the build step (webpack encore) and replacing the front end development with AssetMapper.

In Symfony 7 and 6.4, AssetMapper also supports CSS.

There's an issue with installing datatables (DataTables/DataTablesSrc#246) which I hope gets resolved soon, but there are workarounds in the meantime.

I'm working on a stimulus datatables bundle that may interest you, if you are up for migrating this to AssetMapper (in a version 4 branch) I'd be happy to participate.

[stephenyeargin]

I'm game for it. Anything to simplify the deployment process.

[tacman]

Yeah, right?! You start out saying "just download php and a database" and end up with "and node and yarn or npm but not both, then run a background process to watch the files while you're developing, unless they're in a bundle, where you have to also reinstall the assets...."

I've been playing with AssetMapper a lot. The big step is that it's not compatible with Webpack, so it's not a quick fix. But your code looks like it's going to be straightforward to migrate.

[tacman]

The pages that only require bootstrap are working nicely -- no build step!

https://github.com/tacman/member-directory

check out the assetmapper branch and composer install.

Can you get fos js routing working on the /map page? It requires running the console command to dump the commands as javascript (not json) then loading the library and of course the routes. I'm pretty sure there's a way to do it, but I haven't figured it out. Discussion at

FriendsOfSymfony/FOSJsRoutingBundle#466

[tacman]

I tweaked my branch so that most of the pages work with sqlite, to really simplify the development setup. Now you don't even need to setup a database or run docker.

git clone [email protected]:tacman/member-directory.git --branch sy64-with-assetmapper && cd member-directory
echo "DATABASE_URL=sqlite:///%kernel.project_dir%/var/data.db" > .env.local
composer install
bin/console importmap:install
bin/console doctrine:schema:update --force --complete
bin/console doctrine:fixtures:load -n
symfony server:start -d
symfony open:local

login as [email protected] (password: testing) and enjoy!

Todos

Ideally member-directory would support MySQL, Postgres and sqlite. I think the date functions can be refactored to not have a dependency on the DATE_FORMAT function, or really any database-specific functions.

        dql:
            datetime_functions:
                convert_tz: DoctrineExtensions\Query\Mysql\ConvertTz
                date: DoctrineExtensions\Query\Mysql\Date
                date_format: DoctrineExtensions\Query\Mysql\DateFormat

The javascript files need to move to importmap, setting entryPoint to true, and changing all the 'require' statements to import. And the packages from packages.json need to be reinstalled as importmap, e.g.

bin/console importmap:require gravatar hotkeys-js

It looks like you already have FosJsRouting being loaded with the callback in login.html.twig, I commented them out because I wasn't sure how to do it.

{#    <script src="{{ asset('bundles/fosjsrouting/js/router.min.js') }}"></script>#}
{#    <script src="{{ path('fos_js_routing_js', { callback: 'fos.Router.setData' }) }}"></script>#}
    {{ importmap('app') }}

[stephenyeargin]

There's also some gnarly geolocation queries for finding the search radius when you click on the map. I feel like some of that was MySQL specific.

member-directory/src/Repository/MemberRepository.php

Lines 135 to 160 in 8580866

	public function findMembersWithinRadius(float $latitude, float $longitude, int $radius, $params = [])
	{
	$qb = $this->createQueryBuilder('m')
	->addSelect('t')
	->addSelect('s')
	->addSelect('( 3959 * acos (
	cos ( radians(:latitude) )
	* cos( radians( m.mailingLatitude ) )
	* cos( radians( m.mailingLongitude ) - radians(:longitude) )
	+ sin ( radians(:latitude) )
	* sin( radians( m.mailingLatitude ) )
	) ) AS HIDDEN distance')
	->join('m.status', 's')
	->leftJoin('m.tags', 't')
	->having('distance <= :radius')
	->andWhere('m.mailingLatitude IS NOT NULL')
	->andWhere('m.mailingLatitude != 0')
	->andWhere('m.mailingLongitude IS NOT NULL')
	->andWhere('m.mailingLongitude != 0')
	->andWhere('m.isDeceased = 0')
	->andWhere('s.isInactive = 0')
	->setParameter('latitude', $latitude)
	->setParameter('longitude', $longitude)
	->setParameter('radius', $radius)
	;
	$this->processParams($qb, $params);

[tacman]

yeah, but I'm sure that's a solvable problem. At the moment, the search fails before it gets to the query because of the fos_js_routing issue.

[tacman]

If we really wanted to simplify setup, this repo could include the sqlite file, so that you could download and run without installing the fixtures. That's how the Symfony Demo app works.

[tacman]

I fixed the date functions (DATE_FORMAT, MONTH and DAY) to use SUBSTRING, which I think is portable across databases.

[tacman]

Actually, that didn't work as expected. My fork uses PostgreSQL, so I had to change doctrine.yaml to reflect that for the doctrine extensions.