Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter parameters error - Revit 2020 #18

Open
jpstaub opened this issue Dec 12, 2020 · 3 comments
Open

Filter parameters error - Revit 2020 #18

jpstaub opened this issue Dec 12, 2020 · 3 comments

Comments

@jpstaub
Copy link

jpstaub commented Dec 12, 2020

Hello,

Thank you for all the work on the Revit JSON exporter add-in.

For some reason the exporter fails when trying to filter the parameters of the objects to be exported. Please see below for a sequence of photos showing the general flow of the failure.

I am very inexperienced Visual Studio user. If more debugging information is required to show what's happening please make a specific request and I'll see if I can produce it.

Please note, this may be the same issue reported earlier for Revit 2019 as issue #17.

Best wishes,
Jake Staub

01_Filter parameters

02_Command Failure for External Command

03_Filter Error

@jeremytammik
Copy link
Contributor

Thank you for pin-pointing this issue. the family instance category can be null. in that case, trying to read its name will throw the exception you see. i added a prior check for the null reference. please confirm that this fixes the issue. unfortunately, i did not implement this function myself.

@jeremytammik
Copy link
Contributor

Here is the diff highlighting the fix: 2021.0.0.0...2021.0.0.1

@jpstaub
Copy link
Author

jpstaub commented Dec 20, 2020

Thank you for pin-pointing this issue. the family instance category can be null. in that case, trying to read its name will throw the exception you see. i added a prior check for the null reference. please confirm that this fixes the issue. unfortunately, i did not implement this function myself.

You are welcome.

Thanks for taking the time to post the fix. It resolved the problem.

Best wishes,
Jake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants