Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Atmosphere to 2.7 #10510

Closed
mvysny opened this issue Mar 30, 2021 · 4 comments
Closed

Upgrade Atmosphere to 2.7 #10510

mvysny opened this issue Mar 30, 2021 · 4 comments
Labels
bug Impact: Low Severity: Major

Comments

@mvysny
Copy link
Member

mvysny commented Mar 30, 2021 •
edited
Loading

Atmosphere 2.6.5 will contain an important patch which will make Vaadin run on Quarkus without further workarounds: Atmosphere/atmosphere#2427 . Please upgrade the Atmosphere version to 2.6.5 in flow master once it's released.

Versions:

- Vaadin / Flow version: 20.0.0.alpha5 / 7.0.0.alpha2
@pleku pleku added the quarkus label Apr 7, 2021
@pleku pleku linked a pull request Apr 9, 2021 that will close this issue
fix: use upgraded Atmosphere version for Push #10582
Closed
@pleku
Copy link

pleku commented Apr 9, 2021

This is currently in progress as #10510 but there is a regression in new Atmosphere 2.7.0 which is being handled before we cant proceed.

@pleku
Copy link

pleku commented Jun 10, 2021

The version would need to be 2.7+ instead since the fix didn't land to 2.6, but there is doubt over whether or not it actually fixes the Quarkus + Atmosphere web sockets issue.

@pleku pleku removed the quarkus label Jun 10, 2021
@pleku pleku changed the title Upgrade Atmosphere to 2.6.5 Upgrade Atmosphere to 2.7 Jun 10, 2021
@Artur- Artur- mentioned this issue Sep 27, 2021
Merged
@Artur-
Copy link
Member

Artur- commented Sep 30, 2021

Upgrade reverted because of Atmosphere/atmosphere#2444

@Artur- Artur- reopened this Sep 30, 2021
@caalador
Copy link
Contributor

updated to 2.7.3 in #12738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Impact: Low Severity: Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use upgraded Atmosphere version for Push vaadin/flow
5 participants
@mvysny @Artur- @pleku @caalador @denis-anisimov