New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming all isValidXYZFeature to checkValidXYZFeature within psa token library #42

Open

yogeshbdeshpande opened this issue Nov 3, 2022 · 0 comments

Labels

bug

Contributor

yogeshbdeshpande commented Nov 3, 2022

This issue is a twin issue to the original issue reported in ccatoken repository:

veraison/ccatoken#4

Basically, if the Claim checker functions are named isValidXYZFeature then they should return a boolean.

Otherwise, they should be renamed as checkValidXYZFeature() which would return an error in case any checks fail!

yogeshbdeshpande added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment