Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to catch stalling HTTP connections? #66

Open
willirath opened this issue Apr 26, 2018 · 1 comment
Open

How to catch stalling HTTP connections? #66

willirath opened this issue Apr 26, 2018 · 1 comment

Comments

@willirath
Copy link
Contributor

I'm struggling with an uplink that has stalling HTTP connections from time to time. Currently, conda-mirror just seems to wait forever if this happens during a download. Is there any easy way of adding a timeout / retry on timeout here?
@magnuhho
Copy link
Contributor

We should set a timeout on the requests.get call in _download,
ref. http://docs.python-requests.org/en/master/user/quickstart/#timeouts

This change can be implemented as a command line argument (--timeout) with a default value.

What would be a good value, though? A quick web seearch suggests some products use 10 seconds while other use 2-3 minutes +

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willirath @magnuhho