Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support datetime values #23

Open
mariusvniekerk opened this issue Aug 23, 2017 · 3 comments
Open

Support datetime values #23

mariusvniekerk opened this issue Aug 23, 2017 · 3 comments

Comments

@mariusvniekerk
Copy link
Collaborator

Since avro 1.8.0 support for datetime has been added to the format. We should support reading that.

Sent from my Google Pixel using FastHub

@mariusvniekerk
Copy link
Collaborator Author

These may be harder to do since the C avro api does not support logical types.

@martindurant
Copy link
Contributor

This could easily be done in dask_reader.read_avro_bytes, where there is a step to assign values from those loaded into the pre-allocated dataframe. (That doesn't solve the general problem for those not using the interface)
You can always assign int values directly into a numpy array of time type, but it would require multiplication by some factor to become the correct ns resolution.

@martindurant
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants