-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codec Preference Selection Not Supported in JsSIP #866
Comments
would be nice |
This is a very good suggestion. As an example, Some Safari Mobile versions
don't support OPUS out of the box, this sometimes causes one way audio
between devices.
To better leverage the capacity of SIP proxy servers, this would be vital
because it could help eliminate the work that needs to be done by RTP
proxy, or Media Servers.
…On Tue, Sep 10, 2024 at 1:18 PM ROBERT MCDOWELL ***@***.***> wrote:
would be nice
—
Reply to this email directly, view it on GitHub
<#866 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI64DEOJJMV4VKZ3MC3WTYTZV3PPVAVCNFSM6AAAAABN6TNFLGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBQGU2DEMJUGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
yes, we can handle that as well. I will raise a pull request for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently, JsSIP does not provide a way to set or prioritize specific codecs during the SIP negotiation process. This is a crucial feature for optimizing call quality and adapting to different network conditions. Without the ability to select or prioritize codecs, users have limited control over how media is transmitted, potentially leading to suboptimal call quality or compatibility issues with certain systems.
Expected Behavior
JsSIP should expose a method or option that allows users to:
Set codec preferences (e.g., Opus, G.711, G.729, etc.).
Prioritize codecs by defining an order of preference, which would then be reflected in the SDP offer/answer.
Actual Behavior:
JsSIP currently selects codecs without providing a mechanism to modify the codec order or preference. Users cannot influence which codecs are prioritized during SDP negotiation.
Suggested Enhancement
Add a method (e.g., setCodecPreferences()) that allows developers to define the desired codec order for SIP sessions.
Allow this method to take an array of codec identifiers (such as payload types or names), which would then be used to construct the SDP. Ensure that this functionality works for both audio and video codecs.
Example Usage
This would result in the SDP offer being constructed with the specified codecs in the preferred order.
Impact
This enhancement would significantly improve the flexibility and performance of JsSIP in various network conditions and across different SIP systems by allowing developers to fine-tune the media negotiation process.
The text was updated successfully, but these errors were encountered: