Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: To clear the environment variables #232

Open
yanecc opened this issue Apr 23, 2024 · 6 comments
Open

[Feature]: To clear the environment variables #232

yanecc opened this issue Apr 23, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@yanecc
Copy link
Contributor

yanecc commented Apr 23, 2024

1. Your usage scenarios?

Clear one or all plugin paths introduced by vfox from the $Path environment variable.

2. What is your expected outcome?

vfox disable zig
vfox disable -a/--all
@yanecc yanecc added the enhancement New feature or request label Apr 23, 2024
@aooohan
Copy link
Member

aooohan commented Apr 23, 2024

vfox disable zig
vfox disable -a/--all

I think vfox unuse command is better.

vfox unuse zig@version
vfox unuse zig
vfox unuse --all

@yanecc
Copy link
Contributor Author

yanecc commented Apr 23, 2024

vfox disable zig
vfox disable -a/--all

I think vfox unuse command is better.

vfox unuse zig@version
vfox unuse zig
vfox unuse --all

Well, it's easy to understand, but there is no such a verb😂

@aooohan
Copy link
Member

aooohan commented Apr 23, 2024

Well, it's easy to understand, but there is no such a verb😂

Indeed 😂, But disable is not very appropriate. It can be easily understood as disabling plugins.

If we must use a verb, let's just use clear to clear the environment variables of the specified runtime.

vfox clear zig@version
vfox clear zig
vfox clear --all

WDYT?

@yanecc
Copy link
Contributor Author

yanecc commented Apr 23, 2024

Well, it's easy to understand, but there is no such a verb😂

Indeed 😂, But disable is not very appropriate. It can be easily understood as disabling plugins.

If we must use a verb, let's just use clear to clear the environment variables of the specified runtime.

vfox clear zig@version
vfox clear zig
vfox clear --all

WDYT?

It's ok.
What do you think @version should do to users? Maybe it should be ignored.

@yanecc
Copy link
Contributor Author

yanecc commented Apr 23, 2024

I think the word free being quite fitting. @aooohan

vfox free zig
vfox free -a/--all

@aooohan
Copy link
Member

aooohan commented Apr 23, 2024

What do you think @Version should do to users? Maybe it should be ignored.

Indeed. Runtime name is enough.

I think the word free being quite fitting.

Hmm. From my view, clear is more intuitive.

By the way, we also need to support scopes, like use command.

vfox clear/free --porject zig 
vfox clear/free --global zig 
vfox clear/free --session zig # Default

+1 for clear ;)

@aooohan aooohan modified the milestone: 0.4.2 Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants