Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: display a number of total sessions completed by the user #78

Closed
vimark1 opened this issue Oct 29, 2018 · 3 comments
Closed

Stats: display a number of total sessions completed by the user #78

vimark1 opened this issue Oct 29, 2018 · 3 comments

Comments

@vimark1
Copy link
Owner

vimark1 commented Oct 29, 2018

Add info to profile page, see related #77

@natstar93
Copy link
Contributor

Hiya. I'd like to have a go at this if that's ok. I've pushed a couple of changes to my branch updating the local state with the number of sessions completed: https://github.com/natstar93/typist/commits/display-total-sessions

Just to clarify, is it the total number of sessions they have ever played that needs displaying (i.e. needs to read and write from/to firebase)?

@vimark1
Copy link
Owner Author

vimark1 commented Oct 30, 2018

Hi @natstar93. That would be great!
I wasn't thinking we'd need a Firebase write for this feature.
We basically already store the number of sessions in firebase under the user-score. I was thinking we could query that, which would return all the sessions for all dates and parse the data to calculate number of sessions.

@natstar93
Copy link
Contributor

Oh brilliant. That sounds a lot easier :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants