-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pyvinecopulib > 0.6.5 #161
Comments
Hi, Sorry for missing this issue. We're preparing a pretty big update of pyvinecopulib, switching the backend from pyvind11 to nanobind, including some huge perf improvements from vinecopulib (around 8x speedup in internal benchmarks). Things are currently in the nanobind branch which pass unit tests on all platforms. Given the nature of the error, I suspect this might either solve it (yay) or worsen it. I'm seeing in your raised issue something that is GIL-related, and nanobind has changed how they handle this from pybind11. Importantly, they've introduced a
Can you try replicating using this new version of the package? |
So, the nanobind update is merged into the dev branch. The update will be made available on PyPI in the next few days as version 0.7.0 In the meantime, from the root of the docker image:
Then @Martin-Molinero can you make the use of pyvinecopulib >= 0.7.0 mandatory? |
Nice!
Next time we update our base image, every couple of months, we will look into this 💯 |
Great, then it will definitely be available by then, I'm closing the issue, but feel free to reopen if needed! |
Latest versions seem to be causing runtime explosions, it's not deterministic though, explodes sometimes
How to reproduce:
quantconnect/lean:foundation
git clone https://github.com/QuantConnect/Lean.git && cd Lean && dotnet build /p:Configuration=Release /v:quiet /p:WarningLevel=1 QuantConnect.Lean.sln
pip install pyvinecopulib==0.6.8
dotnet test ./Tests/bin/Release/QuantConnect.Tests.dll --filter "FullyQualifiedName=QuantConnect.Tests.Python.PythonPackagesTests.ShapTest|KerasTest|PyvinecopulibTest"
-> might need to run a couple of times for it to failRelated QuantConnect/Lean#8455
The text was updated successfully, but these errors were encountered: