docs: show old document warning #18805
Conversation
✅ Deploy Preview for vite-docs-v5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
That's actually a really good idea! Gonna steal it for Vitest too 👀 |
There was a problem hiding this comment.
On mobile view, in the config page for example, seems like the navbar can overlap with the top text when scrolling. Not sure if it's easily fixable but I don't think it's a big deal.
Design-wise the bright red background looks kinda scary. Maybe it could use the purple tint color we have, but if others prefer the red too I don't think we have to change it. (Just thinking out loud)
|
Maybe the color could be a bit toned down if the banner isn't dismissible? Maybe using Vite's accent color to make it more integrated. There are people that would like to see old docs. |
Co-authored-by: Bjorn Lu <[email protected]>
|
I changed the background color to the purple brand color. Also fixed the z-index problem with the navbar on mobile. 👍 |
Co-authored-by: Bjorn Lu <[email protected]>
Co-authored-by: Bjorn Lu <[email protected]>
Co-authored-by: Bjorn Lu <[email protected]>
Co-authored-by: Bjorn Lu <[email protected]>
Co-authored-by: Bjorn Lu <[email protected]>
Co-authored-by: Bjorn Lu <[email protected]>
Description
old design
If the design looks good, I'll make a PR to v2,3,4 as well.
fixes #18420