Codestyle #372
Merged
Codestyle #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
previously approved these changes
Feb 28, 2023
|
Would it be useful to have configuration file with excluded files? In that case we would be able to create PRs and reduce list of excluded files step by step. |
@litvinovg can you check my last commit in this PR. If that is what you were thinking in your comment, I can apply similar to VIVO PR. |
Added checkstyle suppressions.
litvinovg
requested changes
Jun 28, 2023
litvinovg
previously approved these changes
Jun 28, 2023
litvinovg
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VIVO GitHub issue: 3814
Linked VIVO PR
https://wiki.lyrasis.org/display/VIVO/Code+Style+Guide
What does this pull request do?
Adding code style into the VIVO/Vitro project
What's new?
checkstyle.xml added into the Vitro root
checkstyle-suppression.xml added in the Vitro root (empty at the moment)
A wiki page added - https://wiki.lyrasis.org/display/VIVO/Code+Style+Guide
checkstyle.xml file linked in pom.xml file (at the moment configured to be skipped)
How should this be tested?
Just for reviewing purposes there is commit with code formatted by using this code style at chenejac@b214563
See instructions for testing in linked VIVO PR
Interested parties
Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers