Skip to content

Commit fce0663

Browse files
mcoquelinFerruh Yigit
authored and
Ferruh Yigit
committed
net/virtio: remove useless pointer checks
This patch removes useless checks on 'prev' pointer, as it is always set before with a valid value. Reviewed-by: David Marchand <[email protected]> Reviewed-by: Tiwei Bie <[email protected]> Signed-off-by: Maxime Coquelin <[email protected]>
1 parent 3291bb2 commit fce0663

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

drivers/net/virtio/virtio_rxtx.c

+4-11
Original file line numberDiff line numberDiff line change
@@ -1512,9 +1512,7 @@ virtio_recv_pkts_inorder(void *rx_queue,
15121512

15131513
rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
15141514

1515-
if (prev)
1516-
prev->next = rxm;
1517-
1515+
prev->next = rxm;
15181516
prev = rxm;
15191517
seg_res -= 1;
15201518
}
@@ -1696,9 +1694,7 @@ virtio_recv_mergeable_pkts(void *rx_queue,
16961694

16971695
rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
16981696

1699-
if (prev)
1700-
prev->next = rxm;
1701-
1697+
prev->next = rxm;
17021698
prev = rxm;
17031699
seg_res -= 1;
17041700
}
@@ -1871,9 +1867,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,
18711867

18721868
rx_pkts[nb_rx]->pkt_len += (uint32_t)(len[i]);
18731869

1874-
if (prev)
1875-
prev->next = rxm;
1876-
1870+
prev->next = rxm;
18771871
prev = rxm;
18781872
seg_res -= 1;
18791873
}
@@ -1916,8 +1910,7 @@ virtio_recv_mergeable_pkts_packed(void *rx_queue,
19161910
} else {
19171911
PMD_RX_LOG(ERR,
19181912
"No enough segments for packet.");
1919-
if (prev)
1920-
virtio_discard_rxbuf(vq, prev);
1913+
virtio_discard_rxbuf(vq, prev);
19211914
rxvq->stats.errors++;
19221915
break;
19231916
}

0 commit comments

Comments
 (0)