Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an app dev, reviewing messages in ...workload get output, I can see the fully qualified reference to the resource which emitted the error #354

Open
heyjcollins opened this issue Sep 28, 2022 · 1 comment

Comments

@heyjcollins
Copy link
Contributor

implementing this change is dependent upon updates to cartographer

There's an ask for them to add a field to their status which provides the fully qualified reference to the resource that's emitting any given message (error or otherwise) which the apps plugin displays in workload get output.

Description of problem

There's currently no obvious and deterministic way for a developer to associate a message that's displayed in the "Messages" section of workload get output with a specific resource.
The absence of this association makes it difficult for a developer to troubleshoot errors when they occur.

Proposed solution

Include the fully qualified reference to the emitting resource in the message that's displayed.

@danfein - please review/update/approve

Example of a current message

Examples

TO DO - provide multiple examples rather than just one
Current message:

Workload [MissingValueAtPath]:   waiting to read value [.status.latestImage] from resource [image.kpack.io/petc] in namespace [default]

New version of message:

Workload [image.kpack.io/petc]:   waiting to read value [.status.latestImage] from resource [image.kpack.io/petc] in namespace [default]

Current message:

 Deliverable [HealthyConditionRule]:   field value: True, message: kapp: Error: Applying update service/petc (serving.knative.dev/v1) namespace: default:
     Updating resource service/petc (serving.knative.dev/v1) namespace: default:
       API server says: admission webhook "validation.webhook.serving.knative.dev" denied the request: validation failed: "PORT" is a reserved environment variable: spec.template.spec.containers[0].env[0].name (reason: BadRequest)

New version of message:

PENDING
@heyjcollins
Copy link
Contributor Author

Not migrated because of the dependency on updates to carto v1 which is unlikely to be prioritized

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants