Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collectd plugin for collecting running transcoder stats #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JulianJacobi
Copy link
Contributor

depends on #13

@JulianJacobi JulianJacobi requested a review from meise November 17, 2019 13:26
Copy link
Contributor

@MaZderMind MaZderMind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but untested, just read

@@ -72,6 +81,13 @@
when: haproxy is defined and haproxy
tags: install

- name: add systemd unit collectd plugin
template:
src: collectd/plugins/TranscodingUnits.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer an all-lower-case filename because of FUD. Or an Emoji.

@saerdnaer
Copy link
Member

@iSchluff was this also integrated into the 36C3 branch, or is this now obsolete?

@iSchluff
Copy link
Member

@saerdnaer No and not yet, but soon (tm)

I am working on something that will make it obsolete.

I think the idea is good but the solution is a bit strange, as acting on the transcoder information would involve talking to graphite. I would rather have just a simple api call.

@Kunsi
Copy link
Contributor

Kunsi commented Dec 26, 2022

Do we still need (and want) this? The PR is now older than 3 years and has conflicts with the base branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants