Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Stylesheet missing #11

Closed
CodeWithDennis opened this issue Aug 23, 2024 · 2 comments · Fixed by #12
Closed

[Bug]: Stylesheet missing #11

CodeWithDennis opened this issue Aug 23, 2024 · 2 comments · Fixed by #12
Labels
bug Something isn't working

Comments

@CodeWithDennis
Copy link
Contributor

CodeWithDennis commented Aug 23, 2024

What happened?

Since the package has been renamed, the stylesheet path in the class is wrong: vendor/vormkracht10/filament-two-factor-auth/resources/dist/filament-two-factor-auth.css. However, this might not be needed if you simply add the Blade files to the content array in the project's Tailwind config. You could include a readme in the package to guide users on adding that line to their file.

import preset from '../../../../vendor/filament/filament/tailwind.config.preset'

export default {
    presets: [preset],
    content: [
        './app/Filament/**/*.php',
        './resources/views/filament/**/*.blade.php',
        './vendor/filament/**/*.blade.php',
        './vendor/vormkracht10/filament-2fa/resources/**/*.blade.php'
    ],
}

How to reproduce the bug

Add package to panel

Package Version

1.1.5

PHP Version

8.2

Laravel Version

10

Which operating systems does with happen with?

macOS

Notes

No response

@CodeWithDennis CodeWithDennis added the bug Something isn't working label Aug 23, 2024
@Baspa Baspa linked a pull request Aug 23, 2024 that will close this issue
@Baspa Baspa closed this as completed in #12 Aug 23, 2024
@Baspa
Copy link
Member

Baspa commented Aug 23, 2024

Oops, that should be fixed in the latest version (v1.1.7).

@CodeWithDennis
Copy link
Contributor Author

CodeWithDennis commented Aug 23, 2024

@Baspa Almost, you forgot to change the viteTheme in the TwoFactorAuthPlugin.php

// L31
->viteTheme('vendor/vormkracht10/filament-two-factor-auth/resources/dist/filament-two-factor-auth.css')

to

// L31
->viteTheme('vendor/vormkracht10/filament-2fa/resources/dist/filament-two-factor-auth.css')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants