This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
Fix warning about needing to instantiate on main #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For iOS we are now indicating through `requiresMainQueueSetup()` returning false that modules do not need to be instantiated on the main thread.
kbetl-dlb
approved these changes
Aug 25, 2023
graduad
deleted the
fix/225-warning-about-needing-to-instantiate-some-modules-on-the-main-thread-ios
branch
mpozy
approved these changes
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For iOS we are now indicating through
requiresMainQueueSetup()returning false that modules do not need to be instantiated on the main thread.